Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1732750
| From | Joe Perches <joe@perches.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [Outreachy kernel] [PATCH] gpu: drm: rockchip: Replace dev_* with DRM_DEV_* |
| Date | 2017-09-15 09:30 +0200 |
| Message-ID | <upTey-833-13@gated-at.bofh.it> (permalink) |
| References | <upSBP-7wK-1@gated-at.bofh.it> <upSLw-7CH-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, 2017-09-15 at 08:58 +0200, Julia Lawall wrote:
>
> On Fri, 15 Sep 2017, Haneen Mohammed wrote:
>
> > This patch replace instances of dev_info/err/debug with
> > DRM_DEV_INFO/ERROR/WARN respectively inorder to use a drm-formatted
> > specific log messages. Issue corrected with the help of the following
> > Coccinelle script:
[]
> > @@ -935,7 +941,8 @@ static void dw_mipi_dsi_encoder_disable(struct drm_encoder *encoder)
> > return;
> >
> > if (clk_prepare_enable(dsi->pclk)) {
> > - dev_err(dsi->dev, "%s: Failed to enable pclk\n", __func__);
> > + DRM_DEV_ERROR(dsi->dev,
> > + "%s: Failed to enable pclk\n", __func__);
The uses of "%s: " ... , __func__ with DRM_DEV_ERROR
is redundant and should be removed.
> > @@ -967,7 +974,8 @@ static void dw_mipi_dsi_encoder_enable(struct drm_encoder *encoder)
> > return;
> >
> > if (clk_prepare_enable(dsi->pclk)) {
> > - dev_err(dsi->dev, "%s: Failed to enable pclk\n", __func__);
> > + DRM_DEV_ERROR(dsi->dev,
> > + "%s: Failed to enable pclk\n", __func__);
etc...
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] gpu: drm: rockchip: Replace dev_* with DRM_DEV_* Haneen Mohammed <hamohammed.sa@gmail.com> - 2017-09-15 08:50 +0200
Re: [Outreachy kernel] [PATCH] gpu: drm: rockchip: Replace dev_* with DRM_DEV_* Julia Lawall <julia.lawall@lip6.fr> - 2017-09-15 09:00 +0200
Re: [Outreachy kernel] [PATCH] gpu: drm: rockchip: Replace dev_* with DRM_DEV_* Joe Perches <joe@perches.com> - 2017-09-15 09:30 +0200
Re: [PATCH] gpu: drm: rockchip: Replace dev_* with DRM_DEV_* Mark yao <mark.yao@rock-chips.com> - 2017-09-15 09:40 +0200
csiph-web