RE: [Intel-wired-lan] [PATCH net-next v3] e1000e: Be drop monitor friendly

From	"Brown, Aaron F" <aaron.f.brown@intel.com>
Newsgroups	linux.kernel
Subject	RE: [Intel-wired-lan] [PATCH net-next v3] e1000e: Be drop monitor friendly
Date	2017-09-15 02:00 +0200
Message-ID	<upMd3-3ak-3@gated-at.bofh.it> (permalink)
References	<uiyeR-3bD-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On Behalf
> Of Florian Fainelli
> Sent: Friday, August 25, 2017 6:14 PM
> To: netdev@vger.kernel.org
> Cc: edumazet@gmail.com; Florian Fainelli <f.fainelli@gmail.com>; open list
> <linux-kernel@vger.kernel.org>; moderated list:INTEL ETHERNET DRIVERS
> <intel-wired-lan@lists.osuosl.org>; davem@davemloft.net
> Subject: [Intel-wired-lan] [PATCH net-next v3] e1000e: Be drop monitor
> friendly
> 
> e1000e_put_txbuf() can be called from normal reclamation path as well as
> when a DMA mapping failure, so we need to differentiate these two cases
> when freeing SKBs to be drop monitor friendly. e1000e_tx_hwtstamp_work()
> and e1000_remove() are processing TX timestamped SKBs and those should
> not be accounted as drops either.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> Changes in v3:
> 
> - differentiate normal reclamation from TX DMA fragment mapping errors
> - removed a few invalid dev_kfree_skb() replacements (those are already
>   drop monitor friendly)
> 
> Changes in v2:
> 
> - make it compile
> 
>  drivers/net/ethernet/intel/e1000e/netdev.c | 18 +++++++++++-------
>  1 file changed, 11 insertions(+), 7 deletions(-)

Tested-by: Aaron Brown <aaron.f.brown@intel.com>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

RE: [Intel-wired-lan] [PATCH net-next v3] e1000e: Be drop monitor         friendly "Brown, Aaron F" <aaron.f.brown@intel.com> - 2017-09-15 02:00 +0200

csiph-web