Re: [PATCH 2/2] integrity: replace call to integrity_read_file with kernel version

From	James Morris <jmorris@namei.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] integrity: replace call to integrity_read_file with kernel version
Date	2017-09-15 01:30 +0200
Message-ID	<upLK1-30B-1@gated-at.bofh.it> (permalink)
References	<up5Ut-1pM-3@gated-at.bofh.it> <up5Ut-1pM-1@gated-at.bofh.it> <upIVP-1fS-11@gated-at.bofh.it> <upJoS-1s3-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 14 Sep 2017, Christoph Hellwig wrote:

> On Fri, Sep 15, 2017 at 06:21:28AM +1000, James Morris wrote:
> > So, to be clear, this patch solves the XFS deadlock using a different 
> > approach (to the now reverted integrity_read approach), which Christoph 
> > also says is more correct generally.  Correct?
> 
> No.  It is in addition to the previous patches - the patches were
> correct for the IMA interaction with the I/O path.  It just turns
> out that the function was also reused for reading certificates
> at initialization time, for which that change was incorrect.
> 
> If this series is applied first the integrity_read code is not
> used for that path any more.

Ok.  Sorry I hadn't looked at the code in detail at this stage during the 
conference and wanting to just revert back to something that Linus can 
safely pull before the merge window closes.


-- 
James Morris
<jmorris@namei.org>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] integrity: replace call to integrity_read_file with kernel version Mimi Zohar <zohar@linux.vnet.ibm.com> - 2017-09-13 04:50 +0200
  Re: [PATCH 2/2] integrity: replace call to integrity_read_file with  kernel version James Morris <jmorris@namei.org> - 2017-09-14 22:30 +0200
    Re: [PATCH 2/2] integrity: replace call to integrity_read_file with  kernel version Christoph Hellwig <hch@infradead.org> - 2017-09-14 23:00 +0200
      Re: [PATCH 2/2] integrity: replace call to integrity_read_file with  kernel version James Morris <jmorris@namei.org> - 2017-09-14 23:10 +0200
      Re: [PATCH 2/2] integrity: replace call to integrity_read_file with  kernel version James Morris <jmorris@namei.org> - 2017-09-15 01:30 +0200

csiph-web