Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1732599

[PATCH v2 1/5] soc: qcom: smem: Use le32_to_cpu for partition size comparison

From Chris Lew <clew@codeaurora.org>
Newsgroups linux.kernel
Subject [PATCH v2 1/5] soc: qcom: smem: Use le32_to_cpu for partition size comparison
Date 2017-09-14 23:30 +0200
Message-ID <upJRU-1Rr-25@gated-at.bofh.it> (permalink)
References <upJRT-1Rr-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Endianness can vary in the system, add le32_to_cpu when comparing
size values from smem.

Signed-off-by: Chris Lew <clew@codeaurora.org>
---

Changes since v1:
- New change

 drivers/soc/qcom/smem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c
index c28275be0038..db04c45d4132 100644
--- a/drivers/soc/qcom/smem.c
+++ b/drivers/soc/qcom/smem.c
@@ -698,7 +698,7 @@ static int qcom_smem_enumerate_partitions(struct qcom_smem *smem,
 			return -EINVAL;
 		}
 
-		if (header->size != entry->size) {
+		if (le32_to_cpu(header->size) != le32_to_cpu(entry->size)) {
 			dev_err(smem->dev,
 				"Partition %d has invalid size\n", i);
 			return -EINVAL;
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 0/5] Qualcomm SMEM V12 Support Chris Lew <clew@codeaurora.org> - 2017-09-14 23:30 +0200
  [PATCH v2 1/5] soc: qcom: smem: Use le32_to_cpu for partition size comparison Chris Lew <clew@codeaurora.org> - 2017-09-14 23:30 +0200
    Re: [PATCH v2 1/5] soc: qcom: smem: Use le32_to_cpu for partition  size comparison Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-09-15 03:10 +0200
    Re: [PATCH v2 1/5] soc: qcom: smem: Use le32_to_cpu for partition  size comparison Stephen Boyd <sboyd@codeaurora.org> - 2017-09-15 20:40 +0200
    Re: [PATCH v2 1/5] soc: qcom: smem: Use le32_to_cpu for partition  size comparison Stephen Boyd <sboyd@codeaurora.org> - 2017-09-15 20:40 +0200
      Re: [PATCH v2 1/5] soc: qcom: smem: Use le32_to_cpu for partition  size comparison Chris Lew <clew@codeaurora.org> - 2017-09-15 23:00 +0200
  [PATCH v2 5/5] soc: qcom: smem: Increase the number of hosts Chris Lew <clew@codeaurora.org> - 2017-09-14 23:30 +0200
    Re: [PATCH v2 5/5] soc: qcom: smem: Increase the number of hosts Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-09-15 20:50 +0200

csiph-web