Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1732509
| Path | csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Clemens Ladisch <clemens@ladisch.de> |
| Newsgroups | linux.kernel |
| Subject | Re: [alsa-devel] [PATCH] ALSA: oxygen: Xonar DG(X): make model_xonar_dg const |
| Date | Thu, 14 Sep 2017 20:50:02 +0200 |
| Message-ID | <upHn4-e8-13@gated-at.bofh.it> (permalink) |
| References | <upD06-62C-11@gated-at.bofh.it> |
| X-Original-To | tiwai@suse.com |
| X-Greylist | delayed 583 seconds by postgrey-1.27 at vger.kernel.org; Thu, 14 Sep 2017 14:40:47 EDT |
| User-Agent | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=utf-8 |
| Content-Language | en-US |
| Content-Transfer-Encoding | 7bit |
| X-Virus-Status | Clean |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 38 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Bhumika Goyal <bhumirks@gmail.com>, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org |
| X-Original-Date | Thu, 14 Sep 2017 20:29:56 +0200 |
| X-Original-Message-ID | <61be1ca9-be7c-763d-d7cd-16b2e434a0f9@ladisch.de> |
| X-Original-References | <1505397855-10618-1-git-send-email-bhumirks@gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1732509 |
Show key headers only | View raw
Bhumika Goyal wrote:
> Make this const as it not modified anywhere. It is only used during a
> copy operation. Also, add const to the declaration in header.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Acked-by: Clemens Ladisch <clemens@ladisch.de>
> ---
> sound/pci/oxygen/xonar_dg.h | 2 +-
> sound/pci/oxygen/xonar_dg_mixer.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/pci/oxygen/xonar_dg.h b/sound/pci/oxygen/xonar_dg.h
> index d461df3..5a07cda 100644
> --- a/sound/pci/oxygen/xonar_dg.h
> +++ b/sound/pci/oxygen/xonar_dg.h
> @@ -51,6 +51,6 @@ void dump_cs4245_registers(struct oxygen *chip,
> void dg_resume(struct oxygen *chip);
> void dg_cleanup(struct oxygen *chip);
>
> -extern struct oxygen_model model_xonar_dg;
> +extern const struct oxygen_model model_xonar_dg;
>
> #endif
> diff --git a/sound/pci/oxygen/xonar_dg_mixer.c b/sound/pci/oxygen/xonar_dg_mixer.c
> index b885dac..d22fbe8 100644
> --- a/sound/pci/oxygen/xonar_dg_mixer.c
> +++ b/sound/pci/oxygen/xonar_dg_mixer.c
> @@ -449,7 +449,7 @@ static int dg_mixer_init(struct oxygen *chip)
> return 0;
> }
>
> -struct oxygen_model model_xonar_dg = {
> +const struct oxygen_model model_xonar_dg = {
> .longname = "C-Media Oxygen HD Audio",
> .chip = "CMI8786",
> .init = dg_init,
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] ALSA: oxygen: Xonar DG(X): make model_xonar_dg const Bhumika Goyal <bhumirks@gmail.com> - 2017-09-14 16:10 +0200 Re: [alsa-devel] [PATCH] ALSA: oxygen: Xonar DG(X): make model_xonar_dg const Clemens Ladisch <clemens@ladisch.de> - 2017-09-14 20:50 +0200 Re: [PATCH] ALSA: oxygen: Xonar DG(X): make model_xonar_dg const Takashi Iwai <tiwai@suse.de> - 2017-09-18 15:50 +0200
csiph-web