Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1732448

Re: [PATCH] xen: don't compile pv-specific parts if XEN_PV isn't configured

Show all headers | View raw

Hi Juergen,

On Thu, Sep 14, 2017 at 02:38:58PM +0200, Juergen Gross wrote:
> xenbus_client.c contains some functions specific for pv guests.
> Enclose them with #ifdef CONFIG_XEN_PV to avoid compiling them when
> they are not needed (e.g. on ARM).
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Thanks for this! I think we also need to drop the old definition,
something like the below. Can you fold this in or should I send it
separately?

Cheers,

Tycho

From 410a0c15c354f1ba387bdac6837d0a2031744c56 Mon Sep 17 00:00:00 2001
From: Tycho Andersen <tycho@docker.com>
Date: Thu, 14 Sep 2017 08:57:30 -0700
Subject: [PATCH] xen, arm64: drop dummy lookup_address()

This is unused, and conflicts with the definition that we'll add for XPFO.

Signed-off-by: Tycho Andersen <tycho@docker.com>
---
 include/xen/arm/page.h | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/include/xen/arm/page.h b/include/xen/arm/page.h
index 415dbc6e43fd..6adc2a955340 100644
--- a/include/xen/arm/page.h
+++ b/include/xen/arm/page.h
@@ -84,16 +84,6 @@ static inline xmaddr_t arbitrary_virt_to_machine(void *vaddr)
 	BUG();
 }
 
-/* TODO: this shouldn't be here but it is because the frontend drivers
- * are using it (its rolled in headers) even though we won't hit the code path.
- * So for right now just punt with this.
- */
-static inline pte_t *lookup_address(unsigned long address, unsigned int *level)
-{
-	BUG();
-	return NULL;
-}
-
 extern int set_foreign_p2m_mapping(struct gnttab_map_grant_ref *map_ops,
 				   struct gnttab_map_grant_ref *kmap_ops,
 				   struct page **pages, unsigned int count);
-- 
2.11.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] xen: don't compile pv-specific parts if XEN_PV isn't configured Juergen Gross <jgross@suse.com> - 2017-09-14 14:40 +0200
  Re: [PATCH] xen: don't compile pv-specific parts if XEN_PV isn't  configured Juergen Gross <jgross@suse.com> - 2017-09-14 16:10 +0200
    Re: [PATCH] xen: don't compile pv-specific parts if XEN_PV isn't  configured Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-09-14 16:10 +0200
  Re: [PATCH] xen: don't compile pv-specific parts if XEN_PV isn't  configured Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-09-14 16:10 +0200
  Re: [PATCH] xen: don't compile pv-specific parts if XEN_PV isn't  configured Tycho Andersen <tycho@docker.com> - 2017-09-14 18:40 +0200
    Re: [PATCH] xen: don't compile pv-specific parts if XEN_PV isn't  configured Juergen Gross <jgross@suse.com> - 2017-09-15 08:00 +0200
  Re: [PATCH] xen: don't compile pv-specific parts if XEN_PV isn't  configured Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-09-18 22:10 +0200

csiph-web