[PATCH v2] Staging: ccree: Use kcalloc instead of kzalloc

From	Srishti Sharma <srishtishar@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH v2] Staging: ccree: Use kcalloc instead of kzalloc
Date	2017-09-14 14:50 +0200
Message-ID	<upBKG-55T-13@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Use kcalloc instead of kzalloc to check for overflow before
multiplication. Done using the following semantic patch by
coccinelle.

http://coccinelle.lip6.fr/rules/kzalloc.cocci

Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
---
Changes in v2:
 - eliminate parentheses around the first argument

 drivers/staging/ccree/ssi_sysfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/ccree/ssi_sysfs.c b/drivers/staging/ccree/ssi_sysfs.c
index 0655658..f7e0c502 100644
--- a/drivers/staging/ccree/ssi_sysfs.c
+++ b/drivers/staging/ccree/ssi_sysfs.c
@@ -376,7 +376,7 @@ static int sys_init_dir(struct sys_dir *sys_dir, struct ssi_drvdata *drvdata,
 		return -ENOMEM;
 	/* allocate memory for directory's attributes list */
 	sys_dir->sys_dir_attr_list =
-		kzalloc(sizeof(struct attribute *) * (num_of_attrs + 1),
+		kcalloc(num_of_attrs + 1, sizeof(struct attribute *),
 			GFP_KERNEL);
 
 	if (!(sys_dir->sys_dir_attr_list)) {
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] Staging: ccree: Use kcalloc instead of kzalloc Srishti Sharma <srishtishar@gmail.com> - 2017-09-14 14:50 +0200
  Re: [Outreachy kernel] [PATCH v2] Staging: ccree: Use kcalloc instead  of kzalloc Julia Lawall <julia.lawall@lip6.fr> - 2017-09-14 15:00 +0200

csiph-web