[PATCH] Staging: lustre: obdclass: Use kcalloc instead of kzalloc

From	Srishti Sharma <srishtishar@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] Staging: lustre: obdclass: Use kcalloc instead of kzalloc
Date	2017-09-14 14:10 +0200
Message-ID	<upB7X-4Sv-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Use kcalloc instead of kzalloc to check for overflow before
multiplication. Done using the following semantic patch by
coccinelle.

http://coccinelle.lip6.fr/rules/kzalloc.cocci

Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
---
 drivers/staging/lustre/lustre/obdclass/cl_object.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/obdclass/cl_object.c b/drivers/staging/lustre/lustre/obdclass/cl_object.c
index 95c7fa3..28cb8489 100644
--- a/drivers/staging/lustre/lustre/obdclass/cl_object.c
+++ b/drivers/staging/lustre/lustre/obdclass/cl_object.c
@@ -1016,7 +1016,7 @@ int cl_global_init(void)
 {
 	int result;
 
-	cl_envs = kzalloc(sizeof(*cl_envs) * num_possible_cpus(), GFP_KERNEL);
+	cl_envs = kcalloc(num_possible_cpus(), sizeof(*cl_envs), GFP_KERNEL);
 	if (!cl_envs) {
 		result = -ENOMEM;
 		goto out;
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] Staging: lustre: obdclass: Use kcalloc instead of kzalloc Srishti Sharma <srishtishar@gmail.com> - 2017-09-14 14:10 +0200
  Re: [Outreachy kernel] [PATCH] Staging: lustre: obdclass: Use kcalloc  instead of kzalloc Julia Lawall <julia.lawall@lip6.fr> - 2017-09-14 14:40 +0200

csiph-web