Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1731309

Re: [PATCH 4.13 20/27] Revert "firmware: add sanity check on shutdown/suspend"

Show all headers | View raw

On Tue, Sep 12, 2017 at 07:20:08PM +0200, Luis R. Rodriguez wrote:
> On Tue, Sep 12, 2017 at 10:00:00AM -0700, Greg Kroah-Hartman wrote:
> > 4.13-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Linus Torvalds <torvalds@linux-foundation.org>
> > 
> > commit f007cad159e99fa2acd3b2e9364fbb32ad28b971 upstream.
> > 
> > This reverts commit 81f95076281fdd3bc382e004ba1bce8e82fccbce.
> 
> I'm not convinced reverting this commit is the right thing to do at
> this point given it would seem other errors were happening prior to
> v4.13 and this commit would rather just bring to light the core of
> the issue which needs to be addressed.

Given that this fixes a reported regression, yes, it is the right thing
to do.

> If reverting this commit please consider reverting also commit
> 06a45a93e7d34a ("firmware: move umh try locks into the umh code").

Ok, I can queue that revert up in my tree and will send it to Linus once
4.14-rc1 is out.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 4.13 20/27] Revert "firmware: add sanity check on shutdown/suspend" Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-09-12 19:10 +0200
  Re: [PATCH 4.13 20/27] Revert "firmware: add sanity check on  shutdown/suspend" "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-09-12 19:30 +0200
    Re: [PATCH 4.13 20/27] Revert "firmware: add sanity check on  shutdown/suspend" Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-09-13 02:50 +0200
      Re: [PATCH 4.13 20/27] Revert "firmware: add sanity check on  shutdown/suspend" "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-09-13 03:30 +0200
        Re: [PATCH 4.13 20/27] Revert "firmware: add sanity check on  shutdown/suspend" Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-09-13 03:50 +0200
      Re: [PATCH 4.13 20/27] Revert "firmware: add sanity check on shutdown/suspend" Linus Torvalds <torvalds@linux-foundation.org> - 2017-09-13 06:20 +0200
        Re: [PATCH 4.13 20/27] Revert "firmware: add sanity check on  shutdown/suspend" "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-09-13 20:40 +0200
          Re: [PATCH 4.13 20/27] Revert "firmware: add sanity check on shutdown/suspend" Linus Torvalds <torvalds@linux-foundation.org> - 2017-09-13 21:40 +0200
            Re: [PATCH 4.13 20/27] Revert "firmware: add sanity check on  shutdown/suspend" "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-09-13 23:50 +0200

csiph-web