Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1730437

Re: [PATCH v11 6/6] target-arm: kvm64: Handle SError interrupt for the guest OS

Show all headers | View raw

On 11 September 2017 at 16:17, gengdongjiu <gengdongjiu@huawei.com> wrote:
>> On 18 August 2017 at 15:23, Dongjiu Geng <gengdongjiu@huawei.com> wrote:
>> > +static int kvm_inject_arm_sei(CPUState *cs) {
>> > +    ARMCPU *cpu = ARM_CPU(cs);
>> > +    CPUARMState *env = &cpu->env;
>> > +
>> > +    unsigned long syndrome = env->exception.vaddress;
>> > +    /* set virtual SError syndrome */
>> > +    if (arm_feature(env, ARM_FEATURE_RAS_EXTENSION)) {
>> > +        syndrome = syndrome & ARM_EL_ISS_MASK;
>> > +    } else {
>> > +        syndrome = 0;
>> > +    }
>> > +
>> > +    return  kvm_vcpu_ioctl(CPU(cpu), KVM_ARM_SEI, &syndrome);
>>
>> This looks odd. If we don't have the RAS extension why do we need to do anything at all here ?
>
> This is because Qemu may need to support non-RAS extension as discussed with ARM James before.
> That is to say host hardware CPU does not support RAS, but guest supports.
> That is under discussion.
> When host hardware supports RAS, specify the syndrome to a valid value, otherwise, set it to 0.

If the guest CPU doesn't support the RAS extension then we have
no mechanism for delivering it a notification about the
memory problem at all, so setting the syndrome to anything
doesn't make sense.

I'm not sure what you should do in the case of "host
supports telling us about a memory problem and has
done so, but guest does not support being told about it",
but I'm pretty sure it shouldn't be this.

thanks
-- PMM

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v11 6/6] target-arm: kvm64: Handle SError interrupt for  the guest OS gengdongjiu <gengdongjiu@huawei.com> - 2017-09-11 17:20 +0200
  Re: [PATCH v11 6/6] target-arm: kvm64: Handle SError interrupt for  the guest OS Peter Maydell <peter.maydell@linaro.org> - 2017-09-11 18:40 +0200
    Re: [PATCH v11 6/6] target-arm: kvm64: Handle SError interrupt for  the guest OS gengdongjiu <gengdongjiu@huawei.com> - 2017-09-13 10:00 +0200
      Re: [PATCH v11 6/6] target-arm: kvm64: Handle SError interrupt for  the guest OS Peter Maydell <peter.maydell@linaro.org> - 2017-09-13 13:00 +0200
        Re: [PATCH v11 6/6] target-arm: kvm64: Handle SError interrupt for  the guest OS gengdongjiu <gengdongjiu@huawei.com> - 2017-09-13 14:00 +0200

csiph-web