Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1730332
| From | Himanshu Jha <himanshujha199640@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] scsi: qla2xxx: remove unnecessary call to memset |
| Date | 2017-09-11 15:00 +0200 |
| Message-ID | <uowtI-3p8-21@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
call to memset to assign 0 value immediately after allocating memory with kzalloc is unnecesaary as kzalloc allocates the memory filled with 0 value. Semantic patch used to resolve this issue: @@ expression e,e2; constant c; statement S; @@ e = kzalloc(e2, c); if(e == NULL) S - memset(e, 0, e2); Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com> --- drivers/scsi/qla2xxx/qla_init.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index b5b48dd..54c1d63 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++ b/drivers/scsi/qla2xxx/qla_init.c @@ -7917,7 +7917,6 @@ struct qla_qpair *qla2xxx_create_qpair(struct scsi_qla_host *vha, int qos, "Failed to allocate memory for queue pair.\n"); return NULL; } - memset(qpair, 0, sizeof(struct qla_qpair)); qpair->hw = vha->hw; qpair->vha = vha; -- 2.7.4
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH] scsi: qla2xxx: remove unnecessary call to memset Himanshu Jha <himanshujha199640@gmail.com> - 2017-09-11 15:00 +0200
csiph-web