Re: Questions about NVMEM

From	Masahiro Yamada <yamada.masahiro@socionext.com>
Newsgroups	linux.kernel
Subject	Re: Questions about NVMEM
Date	2017-09-11 14:50 +0200
Message-ID	<uowk1-3kR-11@gated-at.bofh.it> (permalink)
References	<uooPw-6gw-3@gated-at.bofh.it> <uotmb-15R-27@gated-at.bofh.it> <uouie-1La-19@gated-at.bofh.it> <uov4B-2t7-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Greg


2017-09-11 20:24 GMT+09:00 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> On Mon, Sep 11, 2017 at 07:33:20PM +0900, Masahiro Yamada wrote:
>> >> (Q3) The style of  drivers/nvmem/Makefile
>> >>
>> >> This Makefile looks ugly to me.
>> >> All nvmem drivers are just single file modules.
>> >> Why are they renamed when modules are created?
>> >>
>> >> For the name-space reason for modules,
>> >> prefix "nvmem-" makes sense to me.
>> >>
>> >> It is true that adding "nvmem-" prefix is redundant while
>> >> they are located in drivers/nvmem/ directory,
>> >> but renaming in the Makefile is even more annoying to me.
>> >> Having said that, we may not want to churn this.
>> >
>> > This is mainly done for consistent module naming.
>> > I prefer to have nvmem- prefix for nvmem modules.
>> >
>>
>> I 100% agree that all nvmem modules should have "nvmem-" prefix
>> consistently.
>>
>> My question was, why .c files do not have the same file name as
>> the module name?
>>
>> The more straight-forward way would be:
>> drivers/nvmem/nvmem_core.c
>> drivers/nvmem/nvmem-bcm-ocotp.c
>> drivers/nvmem/nvmem-imx-iim.c
>> etc.
>
> No, the way the current code is, is just fine, please leave it alone, it
> is the style that other subsystems are moving to as well.
>

I did not know that.

OK, if this is the preferred style, let's keep it.



-- 
Best Regards
Masahiro Yamada

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Questions about NVMEM Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-09-11 06:50 +0200
  Re: Questions about NVMEM Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2017-09-11 11:40 +0200
    Re: Questions about NVMEM Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-09-11 12:40 +0200
      Re: Questions about NVMEM Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2017-09-11 13:20 +0200
        Re: Questions about NVMEM Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-09-11 14:50 +0200
          Re: Questions about NVMEM Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2017-09-11 14:50 +0200
      Re: Questions about NVMEM Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-09-11 13:30 +0200
        Re: Questions about NVMEM Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-09-11 14:50 +0200

csiph-web