Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1730322

[PATCH] pci: Add dummy for pci_acs_enabled() if CONFIG_PCI=n to fix iommmu build

Show all headers | View raw

If CONFIG_PCI=n, and gcc (e.g. 4.1.2) decides not to inline
get_pci_function_alias_group(), the build fails with:

    drivers/iommu/iommu.o: In function `get_pci_function_alias_group':
    iommu.c:(.text+0xfdc): undefined reference to `pci_acs_enabled'

Due to the various dummies for PCI calls in the CONFIG_PCI=n case,
pci_acs_enabled() isn't actually ever called, but not all versions of
gcc are smart enough to realize that.

While explicitly marking get_pci_function_alias_group() inline would fix
the build, this would inflate the code for the CONFIG_PCI=y case, as
get_pci_function_alias_group() is a not-so-small function called from
two places.

Hence fix the issue by introducing a dummy for pci_acs_enabled()
instead.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 include/linux/pci.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/linux/pci.h b/include/linux/pci.h
index f68c58a93dd045b9..f4f8ee5a7362e982 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -1685,6 +1685,8 @@ static inline int pci_get_new_domain_nr(void) { return -ENOSYS; }
 
 #define dev_is_pci(d) (false)
 #define dev_is_pf(d) (false)
+static inline bool pci_acs_enabled(struct pci_dev *pdev, u16 acs_flags)
+{ return false; }
 #endif /* CONFIG_PCI */
 
 /* Include architecture-dependent settings and functions */
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] pci: Add dummy for pci_acs_enabled() if CONFIG_PCI=n to fix iommmu build Geert Uytterhoeven <geert@linux-m68k.org> - 2017-09-11 14:30 +0200
  Re: [PATCH] pci: Add dummy for pci_acs_enabled() if CONFIG_PCI=n to  fix iommmu build Joerg Roedel <jroedel@suse.de> - 2017-09-20 14:20 +0200
  Re: [PATCH] pci: Add dummy for pci_acs_enabled() if CONFIG_PCI=n to  fix iommmu build Alex Williamson <alex.williamson@redhat.com> - 2017-09-20 18:20 +0200
  Re: [PATCH] pci: Add dummy for pci_acs_enabled() if CONFIG_PCI=n to  fix iommmu build Bjorn Helgaas <helgaas@kernel.org> - 2017-09-22 18:00 +0200
    Re: [PATCH] pci: Add dummy for pci_acs_enabled() if CONFIG_PCI=n to  fix iommmu build Joerg Roedel <jroedel@suse.de> - 2017-09-22 20:00 +0200
    Re: [PATCH] pci: Add dummy for pci_acs_enabled() if CONFIG_PCI=n to  fix iommmu build Geert Uytterhoeven <geert@linux-m68k.org> - 2017-09-22 20:20 +0200
      Re: [PATCH] pci: Add dummy for pci_acs_enabled() if CONFIG_PCI=n to  fix iommmu build Bjorn Helgaas <helgaas@kernel.org> - 2017-09-25 18:20 +0200

csiph-web