[PATCH 3/4] nvmem: remove inline in drivers/nvmem/core.c

From	srinivas.kandagatla@linaro.org
Newsgroups	linux.kernel
Subject	[PATCH 3/4] nvmem: remove inline in drivers/nvmem/core.c
Date	2017-09-11 11:10 +0200
Message-ID	<uosT8-Sm-11@gated-at.bofh.it> (permalink)
References	<uosT7-Sm-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Masahiro Yamada <yamada.masahiro@socionext.com>

These two functions are defined in .c file, but called just once
(at least for now).  So, the compiler will fold them into their
callers even without the "inline" markers.

However, this kind of optimization should not be done by hand.
It is compiler's judge after all.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 drivers/nvmem/core.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index d12e5de..fdb8b7a 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -946,8 +946,7 @@ void nvmem_cell_put(struct nvmem_cell *cell)
 }
 EXPORT_SYMBOL_GPL(nvmem_cell_put);
 
-static inline void nvmem_shift_read_buffer_in_place(struct nvmem_cell *cell,
-						    void *buf)
+static void nvmem_shift_read_buffer_in_place(struct nvmem_cell *cell, void *buf)
 {
 	u8 *p, *b;
 	int i, bit_offset = cell->bit_offset;
@@ -1028,8 +1027,8 @@ void *nvmem_cell_read(struct nvmem_cell *cell, size_t *len)
 }
 EXPORT_SYMBOL_GPL(nvmem_cell_read);
 
-static inline void *nvmem_cell_prepare_write_buffer(struct nvmem_cell *cell,
-						    u8 *_buf, int len)
+static void *nvmem_cell_prepare_write_buffer(struct nvmem_cell *cell,
+					     u8 *_buf, int len)
 {
 	struct nvmem_device *nvmem = cell->nvmem;
 	int i, rc, nbits, bit_offset = cell->bit_offset;
-- 
2.9.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/4] nvmem: remove inline in drivers/nvmem/core.c srinivas.kandagatla@linaro.org - 2017-09-11 11:10 +0200
  Re: [PATCH 3/4] nvmem: remove inline in drivers/nvmem/core.c Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-09-18 16:10 +0200
    Re: [PATCH 3/4] nvmem: remove inline in drivers/nvmem/core.c Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2017-09-18 17:10 +0200

csiph-web