Re: [PATCH RFC v4 1/3] tracing/irqsoff: Prepare to add preempt and irq trace events

From	Joel Fernandes <joelaf@google.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH RFC v4 1/3] tracing/irqsoff: Prepare to add preempt and irq trace events
Date	2017-09-11 00:30 +0200
Message-ID	<uoiTM-1VD-7@gated-at.bofh.it> (permalink)
References	<umSI1-EN-7@gated-at.bofh.it> <umSI1-EN-11@gated-at.bofh.it> <uo6zg-1DD-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Steven,

On Sun, Sep 10, 2017 at 2:06 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
> On Wed,  6 Sep 2017 17:17:50 -0700
> Joel Fernandes <joelaf@google.com> wrote:
>
>
>> +#else /* IRQSOFF_TRACER || PREEMPTOFF_TRACER */
>> +
>> +#define start_critical_timings_tracer() do { } while (0)
>> +#define stop_critical_timings_tracer() do { } while (0)
>> +
>> +#endif
>> +
>> +#ifndef CONFIG_IRQSOFF_TRACER
>> +#define tracer_hardirqs_on() do { } while (0)
>> +#define tracer_hardirqs_off() do { } while (0)
>> +#define tracer_hardirqs_on_caller(x) do { } while (0)
>> +#define tracer_hardirqs_off_caller(x) do { } while (0)
>> +#endif
>> +
>> +#ifndef CONFIG_PREEMPT_TRACER
>> +#define tracer_preempt_on(x, y) do { } while (0)
>> +#define tracer_preempt_off(x, y) do { } while (0)
>> +#endif
>
> Is there a reason the above is #define and not static inline? The
> preferred method is static inline as that allows the compiler to check
> types. #define is used if one of the parameters has a struct or
> something that is not defined.

Sure, I'll make use of static inline in the next version. thanks!

-Joel

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH RFC v4 1/3] tracing/irqsoff: Prepare to add preempt and irq trace events Joel Fernandes <joelaf@google.com> - 2017-09-07 02:20 +0200
  Re: [PATCH RFC v4 1/3] tracing/irqsoff: Prepare to add preempt and  irq trace events Steven Rostedt <rostedt@goodmis.org> - 2017-09-10 11:20 +0200
    Re: [PATCH RFC v4 1/3] tracing/irqsoff: Prepare to add preempt and  irq trace events Joel Fernandes <joelaf@google.com> - 2017-09-11 00:30 +0200

csiph-web