Re: [PATCH] checkpatch: Fix ignoring cover-letter logic

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] checkpatch: Fix ignoring cover-letter logic
Date	2017-09-10 20:10 +0200
Message-ID	<uoeQ9-7Ap-1@gated-at.bofh.it> (permalink)
References	<unJW2-3gw-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, 2017-09-09 at 18:04 +0900, Stafford Horne wrote:
> Currently running checkpatch on a directory with a cover-letter.patch
> file reports the following error:
> 
>   -----------------------------------------
>   patches/smp-v2/v2-0000-cover-letter.patch
>   -----------------------------------------
> 
>   ERROR: Does not appear to be a unified-diff format patch
> 
> The logic to suppress the unified-diff check for cover letters is there
> but is checking $file instead of $filename.  Fix the variable to use the
> correct one.
> 
> Signed-off-by: Stafford Horne <shorne@gmail.com>

Acked-by: Joe Perches <joe@perches.com>

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -6365,7 +6365,7 @@ sub process {
>  		exit(0);
>  	}
>  
> -	if (!$is_patch && $file !~ /cover-letter\.patch$/) {
> +	if (!$is_patch && $filename !~ /cover-letter\.patch$/) {
>  		ERROR("NOT_UNIFIED_DIFF",
>  		      "Does not appear to be a unified-diff format patch\n");
>  	}

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] checkpatch: Fix ignoring cover-letter logic Stafford Horne <shorne@gmail.com> - 2017-09-09 11:10 +0200
  Re: [PATCH] checkpatch: Fix ignoring cover-letter logic Joe Perches <joe@perches.com> - 2017-09-10 20:10 +0200

csiph-web