Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1731122

[PATCH] drm/vmwgfx: remove DRM_ERROR message, stops log spamming

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

mmap'ing the device multiple times will spam the kernel log with the
DRM_ERROR message about illegal mmap'ing the old fifo space. Since
the mmap'ing will fail with an -EINVAL there is no need to emit this
message, so just remove it.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c
index e771091d2cd3..1e633c602fb1 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c
@@ -33,10 +33,8 @@ int vmw_mmap(struct file *filp, struct vm_area_struct *vma)
 	struct drm_file *file_priv;
 	struct vmw_private *dev_priv;
 
-	if (unlikely(vma->vm_pgoff < VMWGFX_FILE_PAGE_OFFSET)) {
-		DRM_ERROR("Illegal attempt to mmap old fifo space.\n");
+	if (unlikely(vma->vm_pgoff < VMWGFX_FILE_PAGE_OFFSET))
 		return -EINVAL;
-	}
 
 	file_priv = filp->private_data;
 	dev_priv = vmw_priv(file_priv->minor->dev);
-- 
2.14.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] drm/vmwgfx: remove DRM_ERROR message, stops log spamming Colin King <colin.king@canonical.com> - 2017-09-12 19:40 +0200
  Re: [PATCH] drm/vmwgfx: remove DRM_ERROR message, stops log spamming Colin Ian King <colin.king@canonical.com> - 2017-09-12 19:50 +0200
    Re: [PATCH] drm/vmwgfx: remove DRM_ERROR message, stops log spamming Emil Velikov <emil.l.velikov@gmail.com> - 2017-09-12 20:00 +0200
      Re: [PATCH] drm/vmwgfx: remove DRM_ERROR message, stops log spamming Daniel Vetter <daniel@ffwll.ch> - 2017-09-20 20:40 +0200

csiph-web