Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1731001

Re: [PATCH v3 1/5] staging: typec: tcpm: Drop commented out code

Show all headers | View raw

On Tue, Sep 12, 2017 at 10:38:39AM +0300, Heikki Krogerus wrote:
> On Mon, Sep 11, 2017 at 08:32:04PM -0700, Guenter Roeck wrote:
> > Commented out code can be added as needed. Drop it.
> > Also drop TODO and an obsolete XXX comment.
> > 
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > ---
> > v2, v3: No change
> > 
> >  drivers/staging/typec/tcpm.c | 37 +------------------------------------
> >  1 file changed, 1 insertion(+), 36 deletions(-)
> 
> Nice! Just to be sure: The idea is to leave tcpci.c in staging, right?
> 
Yes, until we get test coverage or Greg gets tired of keeping it there
(in that case we would probably have to drop it).

Guenter

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/5] staging: typec: tcpm: Drop commented out code Guenter Roeck <linux@roeck-us.net> - 2017-09-12 05:40 +0200
  [PATCH v3 3/5] staging: typec: pd: Document struct pd_message Guenter Roeck <linux@roeck-us.net> - 2017-09-12 05:40 +0200
  [PATCH v3 2/5] staging: typec: tcpm: Document data structures Guenter Roeck <linux@roeck-us.net> - 2017-09-12 05:40 +0200
  Re: [PATCH v3 1/5] staging: typec: tcpm: Drop commented out code Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2017-09-12 09:50 +0200
    Re: [PATCH v3 1/5] staging: typec: tcpm: Drop commented out code Guenter Roeck <linux@roeck-us.net> - 2017-09-12 18:50 +0200
      Re: [PATCH v3 1/5] staging: typec: tcpm: Drop commented out code Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-09-18 11:10 +0200

csiph-web