Re: [PATCH 7/8] x86/xen: Add unwind hint annotations

From	Josh Poimboeuf <jpoimboe@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 7/8] x86/xen: Add unwind hint annotations
Date	2017-09-12 17:40 +0200
Message-ID	<uoVs6-34g-9@gated-at.bofh.it> (permalink)
References	<ukEg9-217-7@gated-at.bofh.it> <ukEg9-217-11@gated-at.bofh.it> <uoSXf-1pc-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Sep 12, 2017 at 02:56:52PM +0200, Jiri Slaby wrote:
> On 08/31/2017, 10:23 PM, Josh Poimboeuf wrote:
> > Add unwind hint annotations to the xen head code so the ORC unwinder can
> > read head_64.o.
> 
> xen-head.S is included also in head_32.S, so we see:
> arch/x86/kernel/../../x86/xen/xen-head.S:47: Error: no such instruction:
> `unwind_hint_empty'
> scripts/Makefile.build:413: recipe for target
> 'arch/x86/kernel/head_32.o' failed
> 
> To fix this, I use:
> 
> --- a/arch/x86/kernel/head_32.S
> +++ b/arch/x86/kernel/head_32.S
> @@ -25,6 +25,7 @@
>  #include <asm/bootparam.h>
>  #include <asm/export.h>
>  #include <asm/pgtable_32.h>
> +#include "../entry/calling.h"
> 
>  /* Physical address */
>  #define pa(X) ((X) - __PAGE_OFFSET)

Thanks.  0-day reported this as well.  Will fix this in v2.

-- 
Josh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 7/8] x86/xen: Add unwind hint annotations Jiri Slaby <jslaby@suse.cz> - 2017-09-12 15:00 +0200
  Re: [PATCH 7/8] x86/xen: Add unwind hint annotations Josh Poimboeuf <jpoimboe@redhat.com> - 2017-09-12 17:40 +0200

csiph-web