Re: [PATCH] drm: qxl: ratelimit pr_info message, reduce log spamming

From	Gerd Hoffmann <kraxel@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drm: qxl: ratelimit pr_info message, reduce log spamming
Date	2017-09-12 16:30 +0200
Message-ID	<uoUmn-2nc-31@gated-at.bofh.it> (permalink)
References	<uoPZn-7ZB-3@gated-at.bofh.it> <uoU2Z-2g5-7@gated-at.bofh.it> <uoU2Z-2g5-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 2017-09-12 at 17:09 +0300, Dan Carpenter wrote:
> On Tue, Sep 12, 2017 at 03:02:04PM +0100, Emil Velikov wrote:
> > That said, I'm not sure how useful the information is - perhaps
> > it's
> > better to drop it all together?
> 
> Or a WARN_ONCE().

It's userspace calling into the driver with invalid parameters.

IMO we should never WARN_ONCE() on something userspace can trigger.

I'd suggest to just drop the message altogether, simply throwing EINVAL
at userspace is perfectly fine IMHO.

cheers,
  Gerd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drm: qxl: ratelimit pr_info message, reduce log spamming Colin King <colin.king@canonical.com> - 2017-09-12 11:50 +0200
  Re: [PATCH] drm: qxl: ratelimit pr_info message, reduce log spamming Emil Velikov <emil.l.velikov@gmail.com> - 2017-09-12 16:10 +0200
    Re: [PATCH] drm: qxl: ratelimit pr_info message, reduce log spamming Dan Carpenter <dan.carpenter@oracle.com> - 2017-09-12 16:10 +0200
      Re: [PATCH] drm: qxl: ratelimit pr_info message, reduce log spamming Gerd Hoffmann <kraxel@redhat.com> - 2017-09-12 16:30 +0200

csiph-web