Re: [PATCH] pinctrl: uniphier: make arrays static, reduces object code size

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] pinctrl: uniphier: make arrays static, reduces object code size
Date	2017-09-12 16:20 +0200
Message-ID	<uoUcF-2jr-19@gated-at.bofh.it> (permalink)
References	<uoRy9-Ch-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Sep 12, 2017 at 1:21 PM, Colin King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate const arrays on the stack, instead make them
> static.  Makes the object code smaller nearly 1000 bytes. Also
> line break wide lines to avoid checkpatch warnings.
>
> Before:
>    text    data     bss     dec     hex filename
>   13112    1996       0   15108    3b04 pinctrl-uniphier-core.o
>
> After:
>    text    data     bss     dec     hex filename
>   11642    2476       0   14118    3726 pinctrl-uniphier-core.o
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Patch applied with Masahiro's ACK.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] pinctrl: uniphier: make arrays static, reduces object code size Colin King <colin.king@canonical.com> - 2017-09-12 13:30 +0200
  Re: [PATCH] pinctrl: uniphier: make arrays static, reduces object  code size Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-09-12 15:40 +0200
  Re: [PATCH] pinctrl: uniphier: make arrays static, reduces object  code size Linus Walleij <linus.walleij@linaro.org> - 2017-09-12 16:20 +0200

csiph-web