Re: [PATCH 02/14] um: Use %pS printk format for symbols from direct addresses

From	Petr Mladek <pmladek@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 02/14] um: Use %pS printk format for symbols from direct addresses
Date	2017-09-12 14:20 +0200
Message-ID	<uoSkx-17B-5@gated-at.bofh.it> (permalink)
References	<umP7r-6KN-1@gated-at.bofh.it> <umPh8-6O4-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed 2017-09-06 22:27:49, Helge Deller wrote:
> Use the %pS printk format for printing symbols from direct addresses.
> In usermode-linux there is actually no difference between %pS and %pF, but for
> consistency throughout the kernel fix the wrong usage here too.
> 
> Signed-off-by: Helge Deller <deller@gmx.de>
> Cc: Jeff Dike <jdike@addtoit.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: user-mode-linux-devel@lists.sourceforge.net
> ---
>  arch/um/kernel/sysrq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/um/kernel/sysrq.c b/arch/um/kernel/sysrq.c
> index 6b995e8..05585ee 100644
> --- a/arch/um/kernel/sysrq.c
> +++ b/arch/um/kernel/sysrq.c
> @@ -20,7 +20,7 @@
>  
>  static void _print_addr(void *data, unsigned long address, int reliable)
>  {
> -	pr_info(" [<%08lx>] %s%pF\n", address, reliable ? "" : "? ",
> +	pr_info(" [<%08lx>] %s%pS\n", address, reliable ? "" : "? ",
>  		(void *)address);

This seems to be used to print addresses from the stack.
IMHO, we should use %pB here.

Best Regards,
Petr

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 02/14] um: Use %pS printk format for symbols from direct  addresses Petr Mladek <pmladek@suse.com> - 2017-09-12 14:20 +0200
  Re: [PATCH 02/14] um: Use %pS printk format for symbols from direct addresses Richard Weinberger <richard.weinberger@gmail.com> - 2017-09-21 22:20 +0200

csiph-web