Re: [PATCH] btrfs: avoid null pointer dereference on fs_info when calling btrfs_crit

From	David Sterba <dsterba@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH] btrfs: avoid null pointer dereference on fs_info when calling btrfs_crit
Date	2017-09-12 13:30 +0200
Message-ID	<uoRy9-Ch-5@gated-at.bofh.it> (permalink)
References	<uoyFb-57i-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Sep 11, 2017 at 04:15:28PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> There are checks on fs_info in __btrfs_panic to avoid dereferencing a
> null fs_info, however, there is a call to btrfs_crit that may also
> dereference a null fs_info. Fix this by adding a check to see if fs_info
> is null and only print the s_id if fs_info is non-null.
> 
> Detected by CoverityScan CID#401973 ("Dereference after null check")
> 
> Fixes: efe120a067c8 ("Btrfs: convert printk to btrfs_ and fix BTRFS prefix")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: David Sterba <dsterba@suse.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] btrfs: avoid null pointer dereference on fs_info when calling btrfs_crit Colin King <colin.king@canonical.com> - 2017-09-11 17:20 +0200
  Re: [PATCH] btrfs: avoid null pointer dereference on fs_info when  calling btrfs_crit David Sterba <dsterba@suse.cz> - 2017-09-12 13:30 +0200

csiph-web