Re: [PATCH -next] pinctrl: sprd: fix build errors and dependencies

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH -next] pinctrl: sprd: fix build errors and dependencies
Date	2017-09-12 09:40 +0200
Message-ID	<uoNXA-6OK-23@gated-at.bofh.it> (permalink)
References	<um1DI-7e8-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Sep 4, 2017 at 5:35 PM, Randy Dunlap <rdunlap@infradead.org> wrote:

> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build errors when CONFIG_OF is not enabled.
> Also, the pinctrl-sprd-sc9860 driver uses functions from the pinctrl-sprd
> driver, so the former should depend on the latter driver.
>
> ../drivers/pinctrl/sprd/pinctrl-sprd.c: In function 'sprd_dt_node_to_map':
> ../drivers/pinctrl/sprd/pinctrl-sprd.c:290:2: error: implicit declaration of function 'pinconf_generic_parse_dt_config' [-Werror=implicit-function-declaration]
>   ret = pinconf_generic_parse_dt_config(np, pctldev, &configs,
>   ^
> ../drivers/pinctrl/sprd/pinctrl-sprd.c: At top level:
> ../drivers/pinctrl/sprd/pinctrl-sprd.c:844:44: error: array type has incomplete element type
>  static const struct pinconf_generic_params sprd_dt_params[] = {
>                                             ^
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Baolin Wang <baolin.wang@spreadtrum.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-gpio@vger.kernel.org

Patch applied for fixes.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH -next] pinctrl: sprd: fix build errors and dependencies Linus Walleij <linus.walleij@linaro.org> - 2017-09-12 09:40 +0200

csiph-web