Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1730603

Re: [PATCH] f2fs-tools: move_curseg_info only if check_curseg_offset fails

From Chao Yu <yuchao0@huawei.com>
Newsgroups linux.kernel
Subject Re: [PATCH] f2fs-tools: move_curseg_info only if check_curseg_offset fails
Date 2017-09-12 03:30 +0200
Message-ID <uoIbv-2Sd-1@gated-at.bofh.it> (permalink)
References <uodhn-6n2-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 2017/9/11 0:20, Yunlong Song wrote:
> Current design will lose recovery process when check_curseg_offset is OK.
> 
> Signed-off-by: Yunlong Song <yunlong.song@huawei.com>

Reviewed-by: Chao Yu <yuchao0@huawei.com>

> ---
>  fsck/fsck.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/fsck/fsck.c b/fsck/fsck.c
> index cb341ba..56a47be 100644
> --- a/fsck/fsck.c
> +++ b/fsck/fsck.c
> @@ -2026,9 +2026,11 @@ int fsck_verify(struct f2fs_sb_info *sbi)
>  			fix_hard_links(sbi);
>  			fix_nat_entries(sbi);
>  			rewrite_sit_area_bitmap(sbi);
> -			move_curseg_info(sbi, SM_I(sbi)->main_blkaddr);
> -			write_curseg_info(sbi);
> -			flush_curseg_sit_entries(sbi);
> +			if (check_curseg_offset(sbi)) {
> +				move_curseg_info(sbi, SM_I(sbi)->main_blkaddr);
> +				write_curseg_info(sbi);
> +				flush_curseg_sit_entries(sbi);
> +			}
>  			fix_checkpoint(sbi);
>  		} else if (is_set_ckpt_flags(cp, CP_FSCK_FLAG)) {
>  			write_checkpoint(sbi);
> 

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] f2fs-tools: move_curseg_info only if check_curseg_offset fails Yunlong Song <yunlong.song@huawei.com> - 2017-09-10 18:30 +0200
  Re: [PATCH] f2fs-tools: move_curseg_info only if check_curseg_offset  fails Chao Yu <yuchao0@huawei.com> - 2017-09-12 03:30 +0200

csiph-web