Re: [PATCH 1/5] staging: typec: tcpm: Drop commented out code

From	Guenter Roeck <linux@roeck-us.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/5] staging: typec: tcpm: Drop commented out code
Date	2017-09-11 22:00 +0200
Message-ID	<uoD2a-7Me-17@gated-at.bofh.it> (permalink)
References	<uohbj-Dm-3@gated-at.bofh.it> <uozKW-5Lj-13@gated-at.bofh.it> <uoAQF-6s2-11@gated-at.bofh.it> <uoBD4-6YB-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Sep 11, 2017 at 11:26:01AM -0700, Greg Kroah-Hartman wrote:
> On Mon, Sep 11, 2017 at 10:37:11AM -0700, Guenter Roeck wrote:
> > On Mon, Sep 11, 2017 at 09:23:34AM -0700, Greg Kroah-Hartman wrote:
> > > On Sun, Sep 10, 2017 at 01:37:01PM -0700, Guenter Roeck wrote:
> > > > Commented out code can be added as needed. Drop it.
> > > > Also drop TODO and an obsolete XXX comment.
> > > > 
> > > > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > > > ---
> > > >  drivers/staging/typec/tcpm.c | 37 +------------------------------------
> > > >  1 file changed, 1 insertion(+), 36 deletions(-)
> > > 
> > > Thans for the series, I'll queue it up once 4.14-rc1 is out and make a
> > > branch that can get pulled into both the staging and usb trees, so that
> > > future work on this can all happen through the usb tree.
> > > 
> > Should I resend to add the '/**' in patch 3, or can you take care of it ?
> 
> A resend, with -M format, would always be appreciated :)
> 
I did that, as v2, but it does not include the comment change in patch 3.

I'll send v3 tonight.

Guenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/5] staging: typec: tcpm: Drop commented out code Guenter Roeck <linux@roeck-us.net> - 2017-09-10 22:40 +0200
  [PATCH 3/5] staging: typec: pd: Document struct pd_message Guenter Roeck <linux@roeck-us.net> - 2017-09-10 22:40 +0200
    Re: [PATCH 3/5] staging: typec: pd: Document struct pd_message Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-09-11 12:10 +0200
  [PATCH 2/5] staging: typec: tcpm: Document data structures Guenter Roeck <linux@roeck-us.net> - 2017-09-10 22:40 +0200
  Re: [PATCH 4/5] typec: tcpm: Move out of staging Joe Perches <joe@perches.com> - 2017-09-10 22:50 +0200
    Re: [PATCH 4/5] typec: tcpm: Move out of staging Guenter Roeck <linux@roeck-us.net> - 2017-09-10 23:20 +0200
  Re: [PATCH 1/5] staging: typec: tcpm: Drop commented out code Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-09-11 18:30 +0200
    Re: [PATCH 1/5] staging: typec: tcpm: Drop commented out code Guenter Roeck <linux@roeck-us.net> - 2017-09-11 19:40 +0200
      Re: [PATCH 1/5] staging: typec: tcpm: Drop commented out code Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-09-11 20:30 +0200
        Re: [PATCH 1/5] staging: typec: tcpm: Drop commented out code Guenter Roeck <linux@roeck-us.net> - 2017-09-11 22:00 +0200

csiph-web