Re: [PATCH v2 8/8] platform/chrome: cros_ec: sysfs: Modify error handling

From	Benson Leung <bleung@google.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 8/8] platform/chrome: cros_ec: sysfs: Modify error handling
Date	2017-09-11 21:50 +0200
Message-ID	<uoCSt-7IE-13@gated-at.bofh.it> (permalink)
References	<udj6O-4Eb-11@gated-at.bofh.it> <udj6O-4Eb-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Thierry,

On Fri, Aug 11, 2017 at 04:23:05PM +0200, Thierry Escande wrote:
> From: Gwendal Grignou <gwendal@chromium.org>
> 
> When accessing a sysfs attribute, if the EC command fails, -EPROTO is
> now returned instead of an error message as it is unlikely an app is
> parsing the error message to do something meaningful.
> Also, this patch makes use of cros_ec_cmd_xfer_status() instead of
> cros_ec_cmd_xfer() so an error message is printed in the syslog.
> 
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
> Signed-off-by: Thierry Escande <thierry.escande@collabora.com>

Looks good. Applied.

-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2 8/8] platform/chrome: cros_ec: sysfs: Modify error  handling Benson Leung <bleung@google.com> - 2017-09-11 21:50 +0200

csiph-web