Re: [PATCH] btrfs: Clean up dead code in root-tree

From	David Sterba <dsterba@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH] btrfs: Clean up dead code in root-tree
Date	2017-09-11 19:10 +0200
Message-ID	<uoAnD-6hW-7@gated-at.bofh.it> (permalink)
References	<unOVI-6zR-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Sep 09, 2017 at 03:29:34PM +0100, Christos Gkekas wrote:
> The value of variable 'can_recover' is never used after being set, thus
> it should be removed.

Seems it has never been used since introduction in commit
68a7342c51c95042 .

Reviewed-by: David Sterba <dsterba@suse.com>
> 
> Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
> ---
>  fs/btrfs/root-tree.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/fs/btrfs/root-tree.c b/fs/btrfs/root-tree.c
> index 95bcc3c..3338407 100644
> --- a/fs/btrfs/root-tree.c
> +++ b/fs/btrfs/root-tree.c
> @@ -226,10 +226,6 @@ int btrfs_find_orphan_roots(struct btrfs_fs_info *fs_info)
>  	struct btrfs_root *root;
>  	int err = 0;
>  	int ret;
> -	bool can_recover = true;
> -
> -	if (sb_rdonly(fs_info->sb))
> -		can_recover = false;
>  
>  	path = btrfs_alloc_path();
>  	if (!path)
> -- 
> 2.7.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] btrfs: Clean up dead code in root-tree Christos Gkekas <chris.gekas@gmail.com> - 2017-09-09 16:30 +0200
  Re: [PATCH] btrfs: Clean up dead code in root-tree David Sterba <dsterba@suse.cz> - 2017-09-11 19:10 +0200

csiph-web