Re: [PATCH] binder: fix memory corruption in binder_transaction binder

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] binder: fix memory corruption in binder_transaction binder
Date	2017-09-11 19:30 +0200
Message-ID	<uoAH2-6oD-27@gated-at.bofh.it> (permalink)
References	<umpPH-5JK-1@gated-at.bofh.it> <uovQZ-38y-5@gated-at.bofh.it> <uoz8d-5id-11@gated-at.bofh.it> <uoz8d-5id-9@gated-at.bofh.it> <uoAdY-5Xi-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Sep 11, 2017 at 10:25:14PM +0530, Amit Pundir wrote:
> Hi Todd,
> 
> On 11 September 2017 at 21:10, Todd Kjos <tkjos@google.com> wrote:
> > (resend in plain-text mode -- sorry about that)
> >
> > Amit,
> >
> > Are you sure this patch is the culprit? That is pretty surprising
> > since this change can only be hit in a uncommon case (the target node
> > is valid when we start creating the transaction, but dead when we
> > check right before sending it) so it is unlikely to be hit during a
> > normal boot. It also fixes a corruption -- so if you were actually
> > hitting the case, it would likely have caused issues before and not
> > now. Take a look at it and see if you think it is really possible.
> >
> > I just booted hikey to Android with this patch 10 times in a row with
> > no issues (used hikey-linaro 4.9 kernel which has this patch).
> 
> Sorry for not being clear enough in the bug report. android-4.9 is
> fine, I see this issue on linux mainline tree with this patch.

What exact kernel release?  A number of binder fixes have recently
landed in the stable trees, and in Linus's tree.

thanks,

greg k-h

Thread

[PATCH] binder: fix memory corruption in binder_transaction binder Todd Kjos <tkjos@android.com> - 2017-09-05 19:30 +0200
  Re: [PATCH] binder: fix memory corruption in binder_transaction binder Amit Pundir <amit.pundir@linaro.org> - 2017-09-11 14:20 +0200
    Re: [PATCH] binder: fix memory corruption in binder_transaction binder Todd Kjos <tkjos@google.com> - 2017-09-11 17:50 +0200
      Re: [PATCH] binder: fix memory corruption in binder_transaction binder Amit Pundir <amit.pundir@linaro.org> - 2017-09-11 19:00 +0200
        Re: [PATCH] binder: fix memory corruption in binder_transaction  binder Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-09-11 19:30 +0200
        Re: [PATCH] binder: fix memory corruption in binder_transaction binder Todd Kjos <tkjos@google.com> - 2017-09-11 22:00 +0200
          Re: [PATCH] binder: fix memory corruption in binder_transaction binder Martijn Coenen <maco@google.com> - 2017-09-12 10:30 +0200

csiph-web