Re: [PATCH 3.16 153/233] HID: usbhid: add quirk for innomedia INNEX GENESIS/ATARI adapter

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Tomasz Kramkowski <tk@the-tk.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3.16 153/233] HID: usbhid: add quirk for innomedia INNEX GENESIS/ATARI adapter
Date	Sun, 10 Sep 2017 13:50:01 +0200
Message-ID	<uo8Up-39L-5@gated-at.bofh.it> (permalink)
References	<unWqd-3ep-3@gated-at.bofh.it> <unXcC-3OU-43@gated-at.bofh.it>
X-Greylist	delayed 399 seconds by postgrey-1.27 at vger.kernel.org; Sun, 10 Sep 2017 07:40:44 EDT
Dkim-Signature	v=1; a=rsa-sha1; c=relaxed; d=the-tk.com; h=date:from:to :cc:subject:message-id:references:mime-version:content-type :content-transfer-encoding:in-reply-to; s=sel0; bh=zsMDptkahpMrI Uv2yPdDyoivRGU=; b=D0ag04BxCKtKSu0xoUnyUlJgDIBYzqdAlYKKYp6UxxSpl EEd2sBJEiWFCyE5qMVgDiJE3bTtXSRaluE//MI/3aLE6iC1DbnJB8muCNeiQR9Uc t1Lf5N13YcFkDbF0R2xhH7zI1UT0iYtd0OFDmPVo86gn6UWZKje0i8bvbhPKug=
Domainkey-Signature	a=rsa-sha1; c=nofws; d=the-tk.com; h=date:from:to :cc:subject:message-id:references:mime-version:content-type :content-transfer-encoding:in-reply-to; q=dns; s=sel0; b=krvHpJL TCoOO9m5HT2saDzJG3t0a2fT+6y1wG6Wy+issaZ4FeP0EqPTsJe1GBumk3HVLI2O QrKqItbN5kRt+cKJX19ehRHqiHGVvUeBp5BI0VP/YJsT2aBWypqVyYWo6WVhskMc Ohoomk+aLA3WkWwJ62vfRDV7FsaiiaeT1y6Q=
MIME-Version	1.0
Content-Type	text/plain; charset=iso-8859-1
Content-Disposition	inline
Content-Transfer-Encoding	8bit
User-Agent	Mutt/1.5.24 (2015-08-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	54
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, stable@vger.kernel.org, akpm@linux-foundation.org, Jiri Kosina <jkosina@suse.cz>, Benjamin Tissoires <benjamin.tissoires@redhat.com>, Valtteri Heikkilä <rnd@nic.fi>
X-Original-Date	Sun, 10 Sep 2017 12:33:56 +0100
X-Original-Message-ID	<20170910113356.GA22849@gaia.local>
X-Original-References	<lsq.1504993633.197134470@decadent.org.uk> <lsq.1504993634.416795408@decadent.org.uk>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1729964

Show key headers only | View raw

On Sat, Sep 09, 2017 at 10:47:14PM +0100, Ben Hutchings wrote:
> 3.16.48-rc1 review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Tomasz Kramkowski <tk@the-tk.com>
> 
> commit 9547837bdccb4af127528b36a73377150658b4ac upstream.
> 
> The (1292:4745) Innomedia INNEX GENESIS/ATARI adapter needs
> HID_QUIRK_MULTI_INPUT to split the device up into two controllers
> instead of inputs from both being merged into one.
> 
> Signed-off-by: Tomasz Kramkowski <tk@the-tk.com>
> Acked-By: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> [bwh: Backported to 3.16: adjust context]
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---- snip ----

Hi,

Unfortunately this quirk will not make the device mentioned in the commit
work on its own.

This fix was an additional fix on top of another more fundamental fix
which made the device, and others like it, operational. This fix was
included in commit:

Valtteri Heikkilä (1):
      HID: reject input outside logical range only if null state is set
         [3f3752705dbd50b66b66ad7b4d54fe33d2f746ed]

This patch does not appear in your shortlog for this submission and it
doesn't appear when I search linux-stable as of v3.16.47.

Additionally, the following patch might also be helpful in ensuring
the correct operation of the aforementioned device (and other devices
like it):

Tomasz Kramkowski (1):
      HID: clamp input to logical range if no null state
         [c3883fe06488a483658ba5d849b70e49bee15e7c]

However, if the above patches are not appropriate for backporting
to stable then I have absolutely nothing against my patch not being
backported either. My patch alone will not make the device operate in
a useful manner.

Thank you for considering my patch for the 3.16 stable tree and have a
nice day,

-- 
Tomasz Kramkowski

Thread

[PATCH 3.16 153/233] HID: usbhid: add quirk for innomedia INNEX  GENESIS/ATARI adapter Ben Hutchings <ben@decadent.org.uk> - 2017-09-10 01:20 +0200
  Re: [PATCH 3.16 153/233] HID: usbhid: add quirk for innomedia INNEX  GENESIS/ATARI adapter Tomasz Kramkowski <tk@the-tk.com> - 2017-09-10 13:50 +0200
    Re: [PATCH 3.16 153/233] HID: usbhid: add quirk for innomedia INNEX  GENESIS/ATARI adapter Ben Hutchings <ben@decadent.org.uk> - 2017-09-15 19:10 +0200

csiph-web