[PATCH] btrfs: tests: Fix a memory leak in error handling path in 'run_test()'

From	Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Newsgroups	linux.kernel
Subject	[PATCH] btrfs: tests: Fix a memory leak in error handling path in 'run_test()'
Date	2017-09-10 13:30 +0200
Message-ID	<uo8B3-309-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

If 'btrfs_alloc_path()' fails, we must free the resourses already
allocated, as done in the other error handling paths in this function.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 fs/btrfs/tests/free-space-tree-tests.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/btrfs/tests/free-space-tree-tests.c b/fs/btrfs/tests/free-space-tree-tests.c
index 1458bb0ea124..8444a018cca2 100644
--- a/fs/btrfs/tests/free-space-tree-tests.c
+++ b/fs/btrfs/tests/free-space-tree-tests.c
@@ -500,7 +500,8 @@ static int run_test(test_func_t test_func, int bitmaps, u32 sectorsize,
 	path = btrfs_alloc_path();
 	if (!path) {
 		test_msg("Couldn't allocate path\n");
-		return -ENOMEM;
+		ret = -ENOMEM;
+		goto out;
 	}
 
 	ret = add_block_group_free_space(&trans, root->fs_info, cache);
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] btrfs: tests: Fix a memory leak in error handling path in 'run_test()' Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-09-10 13:30 +0200
  Re: [PATCH] btrfs: tests: Fix a memory leak in error handling path in  'run_test()' Qu Wenruo <quwenruo.btrfs@gmx.com> - 2017-09-10 14:00 +0200

csiph-web