[PATCH 1/1] scripts/checkpatch.pl: avoid false warning missing break

From	Heinrich Schuchardt <xypron.glpk@gmx.de>
Newsgroups	linux.kernel
Subject	[PATCH 1/1] scripts/checkpatch.pl: avoid false warning missing break
Date	2017-09-10 10:00 +0200
Message-ID	<uo5jP-Cc-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

void foo(int a)
	switch (a) {
	case 'h':
		fun1();
		exit(1);
	default:
}

creates a warning
Possible switch case/default not preceded by break
or fallthrough comment

exit( should be treated like return.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 scripts/checkpatch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 3afc870f0f..da09b2313c 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -4361,7 +4361,7 @@ sub process {
 				next if ($fline =~ /^.[\s$;]*$/);
 				$has_statement = 1;
 				$count++;
-				$has_break = 1 if ($fline =~ /\bswitch\b|\b(?:break\s*;[\s$;]*$|return\b|goto\b|continue\b)/);
+				$has_break = 1 if ($fline =~ /\bswitch\b|\b(?:break\s*;[\s$;]*$|exit\(\b|return\b|goto\b|continue\b)/);
 			}
 			if (!$has_break && $has_statement) {
 				WARN("MISSING_BREAK",
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] scripts/checkpatch.pl: avoid false warning missing break Heinrich Schuchardt <xypron.glpk@gmx.de> - 2017-09-10 10:00 +0200
  Re: [PATCH 1/1] scripts/checkpatch.pl: avoid false warning missing  break Joe Perches <joe@perches.com> - 2017-09-10 16:20 +0200
    [PATCH v2 1/1] scripts/checkpatch.pl: avoid false warning missing break Heinrich Schuchardt <xypron.glpk@gmx.de> - 2017-09-10 17:50 +0200
      Re: [PATCH v2 1/1] scripts/checkpatch.pl: avoid false warning  missing break Joe Perches <joe@perches.com> - 2017-09-10 20:00 +0200

csiph-web