Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1729912

[PATCH 2/5] vmbus: suppress uevents for hv_sock devices

Show all headers | View raw

From: Dexuan Cui <decui@microsoft.com>

hv_sock driver is automatically loaded when an application creates an
AF_VSOCK socket, so we don't really need to trigger uevents to the user
space udevd.

And hv_sock devices can appear and disappear frequency, e.g. 100 per
second, so triggering the udevents can cause a high cpu utilization of
udevd, e.g. 30% on a 2-cpu virtual machine. So let's suppress the
uevents to avoid this.

Signed-off-by: Dexuan Cui <decui@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
 drivers/hv/vmbus_drv.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index 43160a2eafe0..2c147702ce08 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -1174,6 +1174,8 @@ int vmbus_device_register(struct hv_device *child_device_obj)
 	child_device_obj->device.parent = &hv_acpi_dev->dev;
 	child_device_obj->device.release = vmbus_device_release;
 
+	if (is_hvsock_channel(child_device_obj->channel))
+		dev_set_uevent_suppress(&child_device_obj->device, 1);
 	/*
 	 * Register with the LDM. This will kick off the driver/device
 	 * binding...which will eventually call vmbus_match() and vmbus_probe()
-- 
2.14.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] Drivers: hv: Miscellaneous fixes  kys@exchange.microsoft.com - 2017-09-10 08:00 +0200
  [PATCH 3/5] Drivers: hv: fcopy: restore correct transfer length kys@exchange.microsoft.com - 2017-09-10 08:20 +0200
  [PATCH 2/5] vmbus: suppress uevents for hv_sock devices kys@exchange.microsoft.com - 2017-09-10 08:20 +0200
    Re: [PATCH 2/5] vmbus: suppress uevents for hv_sock devices Greg KH <gregkh@linuxfoundation.org> - 2017-09-10 11:30 +0200
      RE: [PATCH 2/5] vmbus: suppress uevents for hv_sock devices KY Srinivasan <kys@microsoft.com> - 2017-09-18 02:10 +0200
  [PATCH 4/5] vmbus: add per-channel sysfs info kys@exchange.microsoft.com - 2017-09-10 08:20 +0200
  [PATCH 1/5] vmbus: don't acquire the mutex in vmbus_hvsock_device_unregister() kys@exchange.microsoft.com - 2017-09-10 08:20 +0200
    [PATCH 5/5] Drivers: hv: vmbus: Expose per-channel event counters  kys@exchange.microsoft.com - 2017-09-10 08:20 +0200

csiph-web