Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1729131

Re: [Outreachy kernel] [PATCH v2] staging: typec: tcpm: Comparison to NULL pointer

Show all headers | View raw

Maybe "Rewrite comparison to NULL pointer" in the subject to include what
was done, not just code was touched.

On Fri, 8 Sep 2017, Harsha Sharma wrote:

> Makes code more concise and readable

Makes -> Make.  Commit logs should be written in the imperative, like you
are telling someone what to do.

julia

> Signed-off-by: Harsha Sharma <harshasharmaiitr@gmail.com>
> ---
> Change in v2:
>  -Change in subject
>  -Change in log message
>  drivers/staging/typec/tcpm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c
> index 630fe75..9f4a5a5 100644
> --- a/drivers/staging/typec/tcpm.c
> +++ b/drivers/staging/typec/tcpm.c
> @@ -982,7 +982,7 @@ static void svdm_consume_modes(struct tcpm_port *port, const __le32 *payload,
>  	}
>  	port->partner_altmode[pmdata->altmodes] =
>  		typec_partner_register_altmode(port->partner, paltmode);
> -	if (port->partner_altmode[pmdata->altmodes] == NULL) {
> +	if (!port->partner_altmode[pmdata->altmodes]) {
>  		tcpm_log(port,
>  			 "Failed to register alternate modes for SVID 0x%04x",
>  			 paltmode->svid);
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1504892391-5607-1-git-send-email-harshasharmaiitr%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] staging: typec: tcpm: Comparison to NULL pointer  Harsha Sharma <harshasharmaiitr@gmail.com> - 2017-09-08 19:50 +0200
  Re: [Outreachy kernel] [PATCH v2] staging: typec: tcpm: Comparison  to NULL pointer Julia Lawall <julia.lawall@lip6.fr> - 2017-09-08 19:50 +0200

csiph-web