Re: [PATCH] drm/vc4: clean up error handling on devm_kzalloc failure

From	Eric Anholt <eric@anholt.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drm/vc4: clean up error handling on devm_kzalloc failure
Date	2017-09-08 20:10 +0200
Message-ID	<unvT5-24G-29@gated-at.bofh.it> (permalink)
References	<unrmp-7tU-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Colin King <colin.king@canonical.com> writes:

> From: Colin Ian King <colin.king@canonical.com>
>
> The current error handling on devm_kzalloc failures performs a non-null
> check on connector. Thss check is redundant because connector is null
> at that failure point.  With this check removed, we may as well make
> the failure path into a trivial -ENOMEM return to clean up the error
> handling.
>
> Detected by CoverityScan CID#1339527 ("Logically dead code")

Reviewed and applied.  Thanks!

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drm/vc4: clean up error handling on devm_kzalloc failure Colin King <colin.king@canonical.com> - 2017-09-08 15:20 +0200
  Re: [PATCH] drm/vc4: clean up error handling on devm_kzalloc failure Emil Velikov <emil.l.velikov@gmail.com> - 2017-09-08 15:50 +0200
  Re: [PATCH] drm/vc4: clean up error handling on devm_kzalloc failure Eric Engestrom <eric.engestrom@imgtec.com> - 2017-09-08 16:30 +0200
  Re: [PATCH] drm/vc4: clean up error handling on devm_kzalloc failure Eric Anholt <eric@anholt.net> - 2017-09-08 20:10 +0200

csiph-web