Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1729082

Re: [PATCH v2 1/3] ASoC: samsung: i2s: Use specific name for i2s dais

Show all headers | View raw

On Wed, Sep 06, 2017 at 10:04:13AM +0900, Jaechul Lee wrote:
> Add specific dais name when components are registered. Component and dai
> name will follow their parent dev name, if the name isn't described.  In
> case of this driver, each dais will have same name like '11440000.i2s0' by
> fmt_single_name function.
> 
> The problem having same name is that TM2 machine driver can't detect
> capture devices correctly. Machine driver doesn't know which one is proper
> to use for cpu dai. The driver just selects to use 'samsung-i2c-sec' that
> doesn't have capture functionality because the component of
> samsung-i2s-sec is located in the first of the component_list.
> 
> I add dai name like 'samsung-i2s', 'samsung-i2s-sec' for each dais. The
> reason why adding dai id to 1 is that it doesn't allow to use particular
> dai name in case of when I use 0 for dai id.
> 
> Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
> ---
>  sound/soc/samsung/i2s.c | 4 ++++
>  sound/soc/samsung/i2s.h | 3 +++
>  2 files changed, 7 insertions(+)
> 

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/3] ASoC: samsung: i2s: Use specific name for i2s dais Jaechul Lee <jcsing.lee@samsung.com> - 2017-09-06 03:10 +0200
  Re: [PATCH v2 1/3] ASoC: samsung: i2s: Use specific name for i2s dais Krzysztof Kozlowski <krzk@kernel.org> - 2017-09-08 18:50 +0200

csiph-web