Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1728990

Re: [PATCH v5 1/3] perf config: Check not only section->from_system_config but also item's

Show all headers | View raw

Em Thu, Sep 07, 2017 at 12:18:45PM +0900, Taeung Song escreveu:
> Currently only section->from_system_config is being checked multiple times.
> items->from_system_config should be also checked, so fix it.

Reworded the cset log as:

    perf config: Check not only section->from_system_config but also item's
    
    Currently section->from_system_config is being checked multiple times.
    item->from_system_config should be checked instead, when iterating thru
    the items in a section. Fix it.


applied.

- Arnaldo
 
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
> ---
>  tools/perf/builtin-config.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c
> index 3ddcc6e..a1d82e3 100644
> --- a/tools/perf/builtin-config.c
> +++ b/tools/perf/builtin-config.c
> @@ -59,7 +59,7 @@ static int set_config(struct perf_config_set *set, const char *file_name,
>  		fprintf(fp, "[%s]\n", section->name);
>  
>  		perf_config_items__for_each_entry(&section->items, item) {
> -			if (!use_system_config && section->from_system_config)
> +			if (!use_system_config && item->from_system_config)
>  				continue;
>  			if (item->value)
>  				fprintf(fp, "\t%s = %s\n",
> -- 
> 2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v5 1/3] perf config: Check not only section->from_system_config but also item's Taeung Song <treeze.taeung@gmail.com> - 2017-09-07 05:20 +0200
  Re: [PATCH v5 1/3] perf config: Check not only  section->from_system_config but also item's Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-08 16:40 +0200

csiph-web