Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1728988

Re: [PATCH] Staging: media: omap4iss: Use WARN_ON() instead of BUG_ON().

Show all headers | View raw

On Fri, Sep 08, 2017 at 07:38:18PM +0530, Srishti Sharma wrote:
> Use WARN_ON() instead of BUG_ON() to avoid crashing the kernel.
> 
> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
> ---
>  drivers/staging/media/omap4iss/iss.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c
> index c26c99fd..b1036ba 100644
> --- a/drivers/staging/media/omap4iss/iss.c
> +++ b/drivers/staging/media/omap4iss/iss.c
> @@ -893,7 +893,7 @@ void omap4iss_put(struct iss_device *iss)
>  		return;
> 
>  	mutex_lock(&iss->iss_mutex);
> -	BUG_ON(iss->ref_count == 0);
> +	WARN_ON(iss->ref_count == 0);

ref_counting bugs often have a security aspect.  BUG_ON() is probably
safer here.  Better to crash than to lose all your bitcoin.

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Staging: media: omap4iss: Use WARN_ON() instead of BUG_ON(). Srishti Sharma <srishtishar@gmail.com> - 2017-09-08 16:10 +0200
  Re: [Outreachy kernel] [PATCH] Staging: media: omap4iss: Use WARN_ON()  instead of BUG_ON(). Julia Lawall <julia.lawall@lip6.fr> - 2017-09-08 16:20 +0200
    Re: [Outreachy kernel] [PATCH] Staging: media: omap4iss: Use  WARN_ON() instead of BUG_ON(). Srishti Sharma <srishtishar@gmail.com> - 2017-09-08 16:20 +0200
  Re: [PATCH] Staging: media: omap4iss: Use WARN_ON() instead of  BUG_ON(). Dan Carpenter <dan.carpenter@oracle.com> - 2017-09-08 16:40 +0200
    Re: [PATCH] Staging: media: omap4iss: Use WARN_ON() instead of BUG_ON(). Srishti Sharma <srishtishar@gmail.com> - 2017-09-08 17:00 +0200

csiph-web