Re: [PATCH v5 3/3] perf config: Allow creating empty config set for config file autogeneration

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 3/3] perf config: Allow creating empty config set for config file autogeneration
Date	Fri, 08 Sep 2017 16:40:01 +0200
Message-ID	<unsBP-8jV-3@gated-at.bofh.it> (permalink)
References	<umVwd-2xy-5@gated-at.bofh.it>
X-Original-To	Taeung Song <treeze.taeung@gmail.com>
Dmarc-Filter	OpenDMARC Filter v1.3.2 mail.kernel.org EC1FC22AA8
Authentication-Results	mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org
Authentication-Results	mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
X-URL	http://acmel.wordpress.com
User-Agent	Mutt/1.8.3 (2017-05-23)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	63
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, taeung@kosslab.kr, Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>
X-Original-Date	Fri, 8 Sep 2017 11:36:28 -0300
X-Original-Message-ID	<20170908143628.GB10112@kernel.org>
X-Original-References	<1504754336-9824-1-git-send-email-treeze.taeung@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1728980

Show key headers only | View raw

Em Thu, Sep 07, 2017 at 12:18:56PM +0900, Taeung Song escreveu:
> When there isn't a config file (e.g. ~/.perfconfig)
> or it has nothing, the config set wasn't created.
> If the config set not exists, a config file can't be autogenerated.
> 
> So allow creating a empty config set in the above case,
> then we can support the config file autogeneration.

Applied, and rephased a bit the cset log message.

- Arnaldo
 
> Before:
> 
>   $ rm -f ~/.perfconfig
>   $ perf config --user report.children=false
> 
>   $ cat ~/.perfconfig
>   cat: /root/.perfconfig: No such file or directory
> 
> But I think it should work even if there isn't a config file.
> 
> After:
> 
>   $ rm -f ~/.perfconfig
>   $ perf config --user report.children=false
> 
>   $ cat ~/.perfconfig
>   # this file is auto-generated.
>   [report]
>       children = false
> 
> NOTE:
> As a result, if perf_config_set__init() is failed,
> it seems that the config set isn't freed. But it isn't a problem.
> Because the config set  will be freed by perf_config_set__delete()
> at the end of cmd_config().
> 
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
> ---
>  tools/perf/util/config.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c
> index bc75596..d2b6983 100644
> --- a/tools/perf/util/config.c
> +++ b/tools/perf/util/config.c
> @@ -700,10 +700,7 @@ struct perf_config_set *perf_config_set__new(void)
>  
>  	if (set) {
>  		INIT_LIST_HEAD(&set->sections);
> -		if (perf_config_set__init(set) < 0) {
> -			perf_config_set__delete(set);
> -			set = NULL;
> -		}
> +		perf_config_set__init(set);
>  	}
>  
>  	return set;
> -- 
> 2.7.4

Thread

[PATCH v5 3/3] perf config: Allow creating empty config set for config file autogeneration Taeung Song <treeze.taeung@gmail.com> - 2017-09-07 05:20 +0200
  Re: [PATCH v5 3/3] perf config: Allow creating empty config set for  config file autogeneration Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-08 16:40 +0200
    Re: [PATCH v5 3/3] perf config: Allow creating empty config set for  config file autogeneration Taeung Song <treeze.taeung@gmail.com> - 2017-09-08 20:00 +0200

csiph-web