Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1728741

Re: [Outreachy kernel] [PATCH v4] staging: pi433: Fixes minor typo errors

Show all headers | View raw

On Fri, 8 Sep 2017, Dan Carpenter wrote:

> On Fri, Sep 08, 2017 at 11:45:20AM +0200, Julia Lawall wrote:
> >
> >
> > On Fri, 8 Sep 2017, harsha wrote:
> >
> > > From: Harsha Sharma <harshasharmaiitr@gmail.com>
> > >
> > > Fixes checkpatch warning -- "occured" and "succesfully" are misspelled
> > >
> > > Signed-off-by: Harsha Sharma <harshasharmaiitr@gmail.com>
> > > ---
> > > Changes in v4:
> > >  -Correct the format of the subject.
> > >  -Signed-off properly.
> >
> > It's not signed off properly.  Like Greg just said (maybe the mails
> > crossed), the sign off needs to be the same as the From line.  This
> > probably relates to your git configuration or your mailer.  Send the patch
> > to yourself before sending it out on the mailing list to be sure that
> > everything is ok.
> >
>
> This is actually OK-ish...  It's better when we don't have the extra
> From: and there is no need for that with gmail, but we sometimes allow
> it for companies which have broken mailservers.

Oops, I'm sorry. I didn't see the extra From line.

SubmittingPatches says that the From line should be provided:

The ``from`` line must be the very first line in the message body,
and has the form:

        From: Original Author <author@example.com>

It does say:

If the ``from`` line is missing, then the ``From:`` line from the email
header will be used to determine the patch author in the changelog.

But it doesn't convey the same spirit as "we sometimes allow".

julia


>
> regards,
> dan carpenter
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170908095039.ns6kjwa2j5jbrrbi%40mwanda.
> For more options, visit https://groups.google.com/d/optout.
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [Outreachy kernel] [PATCH v4] staging: pi433: Fixes minor typo  errors Julia Lawall <julia.lawall@lip6.fr> - 2017-09-08 11:50 +0200
  Re: [Outreachy kernel] [PATCH v4] staging: pi433: Fixes minor typo  errors Julia Lawall <julia.lawall@lip6.fr> - 2017-09-08 12:00 +0200
    Re: [Outreachy kernel] [PATCH v4] staging: pi433: Fixes minor typo  errors Dan Carpenter <dan.carpenter@oracle.com> - 2017-09-08 12:50 +0200
  Re: [Outreachy kernel] [PATCH v4] staging: pi433: Fixes minor typo  errors Dan Carpenter <dan.carpenter@oracle.com> - 2017-09-08 12:00 +0200

csiph-web