Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1728732

Re: [PATCH 1/2] staging: typec: tcpm: Validate source and sink caps

Show all headers | View raw

On Thu, Sep 07, 2017 at 06:22:13PM -0700, Badhri Jagan Sridharan wrote:
> The source and sink caps should follow the following rules.
> This patch validates whether the src_caps/snk_caps adheres
> to it.
> 
> 6.4.1 Capabilities Message
> A Capabilities message (Source Capabilities message or Sink
> Capabilities message) shall have at least one Power
> Data Object for vSafe5V. The Capabilities message shall also
> contain the sending Port’s information followed by up to
> 6 additional Power Data Objects. Power Data Objects in a
> Capabilities message shall be sent in the following order:
> 
> 1. The vSafe5V Fixed Supply Object shall always be the first object.
> 2. The remaining Fixed Supply Objects, if present, shall be sent
>    in voltage order; lowest to highest.
> 3. The Battery Supply Objects, if present shall be sent in Minimum
>    Voltage order; lowest to highest.
> 4. The Variable Supply (non-battery) Objects, if present, shall be
>    sent in Minimum Voltage order; lowest to highest.
> 
> Errors in source/sink_caps of the local port will prevent
> the port registration. Whereas, errors in source caps of partner
> device would only log them.
> 
> Signed-off-by: Badhri Jagan Sridharan <Badhri@google.com>
> ---
>  drivers/staging/typec/pd.h   |   2 +
>  drivers/staging/typec/tcpm.c | 107 +++++++++++++++++++++++++++++++++++++++----
>  drivers/staging/typec/tcpm.h |  16 +++----
>  3 files changed, 108 insertions(+), 17 deletions(-)

Before you add more stuff to this driver, what is needed to get it out
of staging?  That would be more useful to do now, right?

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] staging: typec: tcpm: Validate source and sink caps Badhri Jagan Sridharan <badhri@google.com> - 2017-09-08 03:30 +0200
  [PATCH 2/2] staging: typec: tcpm: Only request matching pdos Badhri Jagan Sridharan <badhri@google.com> - 2017-09-08 03:30 +0200
    Re: [PATCH 2/2] staging: typec: tcpm: Only request matching pdos Dan Carpenter <dan.carpenter@oracle.com> - 2017-09-08 11:40 +0200
      Re: [PATCH 2/2] staging: typec: tcpm: Only request matching pdos Badhri Jagan Sridharan <badhri@google.com> - 2017-09-08 19:50 +0200
        Re: [PATCH 2/2] staging: typec: tcpm: Only request matching pdos Dan Carpenter <dan.carpenter@oracle.com> - 2017-09-09 10:50 +0200
          Re: [PATCH 2/2] staging: typec: tcpm: Only request matching pdos Guenter Roeck <linux@roeck-us.net> - 2017-09-09 16:10 +0200
  Re: [PATCH 1/2] staging: typec: tcpm: Validate source and sink caps Dan Carpenter <dan.carpenter@oracle.com> - 2017-09-08 11:40 +0200
    Re: [PATCH 1/2] staging: typec: tcpm: Validate source and sink caps Badhri Jagan Sridharan <badhri@google.com> - 2017-09-08 19:30 +0200
      Re: [PATCH 1/2] staging: typec: tcpm: Validate source and sink caps Dan Carpenter <dan.carpenter@oracle.com> - 2017-09-09 00:00 +0200
  Re: [PATCH 1/2] staging: typec: tcpm: Validate source and sink caps Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-09-08 11:50 +0200
    Re: [PATCH 1/2] staging: typec: tcpm: Validate source and sink caps Badhri Jagan Sridharan <badhri@google.com> - 2017-09-08 19:40 +0200
      Re: [PATCH 1/2] staging: typec: tcpm: Validate source and sink caps Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-09-08 21:20 +0200
        Re: [PATCH 1/2] staging: typec: tcpm: Validate source and sink caps Guenter Roeck <linux@roeck-us.net> - 2017-09-09 16:10 +0200
        Re: [PATCH 1/2] staging: typec: tcpm: Validate source and sink caps Guenter Roeck <linux@roeck-us.net> - 2017-09-09 19:00 +0200
          Re: [PATCH 1/2] staging: typec: tcpm: Validate source and sink caps Guenter Roeck <linux@roeck-us.net> - 2017-09-09 19:00 +0200
          Re: [PATCH 1/2] staging: typec: tcpm: Validate source and sink caps Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-09-10 17:30 +0200

csiph-web