Re: [Intel-wired-lan] [PATCH] e1000e: changed some expensive calls of udelay to usleep_range

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Pavel Machek <pavel@ucw.cz>
Newsgroups	linux.kernel
Subject	Re: [Intel-wired-lan] [PATCH] e1000e: changed some expensive calls of udelay to usleep_range
Date	Fri, 08 Sep 2017 11:30:01 +0200
Message-ID	<unnLP-4OG-1@gated-at.bofh.it> (permalink)
References	<ujIYx-821-5@gated-at.bofh.it> <um2q6-7L6-13@gated-at.bofh.it> <undt8-6g1-11@gated-at.bofh.it>
X-Original-To	"Brown, Aaron F" <aaron.f.brown@intel.com>
MIME-Version	1.0
Content-Type	multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TiqCXmo5T1hvSQQg"
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	65
Organization	linux.* mail to news gateway
X-Original-Cc	Matthew Tan <matthew.tan_1@nxp.com>, "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>, "michael.kardonik@nxp.com" <michael.kardonik@nxp.com>, "Williams, Mitch A" <mitch.a.williams@intel.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>
X-Original-Date	Fri, 8 Sep 2017 11:28:27 +0200
X-Original-Message-ID	<20170908092827.GC18365@amd>
X-Original-References	<1503503985-3869-1-git-send-email-matthew.tan_1@nxp.com> <20170904162555.GB21849@amd> <309B89C4C689E141A5FF6A0C5FB2118B8C69E5E5@ORSMSX101.amr.corp.intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1728715

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu 2017-09-07 22:19:47, Brown, Aaron F wrote:
> > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On
> > Behalf Of Pavel Machek
> > Sent: Monday, September 4, 2017 9:26 AM
> > To: Matthew Tan <matthew.tan_1@nxp.com>
> > Cc: michael.kardonik@nxp.com; Williams, Mitch A
> > <mitch.a.williams@intel.com>; linux-kernel@vger.kernel.org;
> > john.ronciak@intel.com; intel-wired-lan@lists.osuosl.org;
> > netdev@vger.kernel.org
> > Subject: Re: [Intel-wired-lan] [PATCH] e1000e: changed some expensive calls
> > of udelay to usleep_range
> > 
> > Hi!
> > 
> > > @@ -183,7 +183,7 @@ s32 e1000e_read_phy_reg_mdic(struct e1000_hw
> > *hw, u32 offset, u16 *data)
> > >  	 * reading duplicate data in the next MDIC transaction.
> > >  	 */
> > >  	if (hw->mac.type == e1000_pch2lan)
> > > -		udelay(100);
> > > +		usleep_range(90, 100);
> > >
> > >  	return 0;
> > >  }
> > 
> > Can you explain why shortening the delay is acceptable here?
> 
> Maybe it's not.
> 
> This patch is causing speed / duplex tests to fail on several of my test systems.  Specifically a Lenova laptop with an 82577 and a NUC with an i218 (though that does not mean it is limited to those or that it's not related to the individual link partner.)
>

Ok, this should be quite easy to verify -- just adjust all the ranges
to be >= original ones.

Thanks,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] e1000e: changed some expensive calls of udelay to  usleep_range Pavel Machek <pavel@ucw.cz> - 2017-09-04 18:30 +0200
  RE: [Intel-wired-lan] [PATCH] e1000e: changed some expensive calls  of udelay to usleep_range "Brown, Aaron F" <aaron.f.brown@intel.com> - 2017-09-08 00:30 +0200
    Re: [Intel-wired-lan] [PATCH] e1000e: changed some expensive calls  of udelay to usleep_range Pavel Machek <pavel@ucw.cz> - 2017-09-08 11:30 +0200

csiph-web