Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1728691

[PATCH 1/3] tools lib api: Fix make DEBUG=1 build

Show all headers | View raw

Do not use -D_FORTIFY_SOURCE=2 for DEBUG build as it seems to
mess up with debuginfo, which results in bad gdb experience.

We already do that for perf.

Link: http://lkml.kernel.org/n/tip-mfg2ly8i01dyx1tku813b3wt@git.kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
 tools/lib/api/Makefile | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/tools/lib/api/Makefile b/tools/lib/api/Makefile
index 4563ba7ede6f..1e83e3c07448 100644
--- a/tools/lib/api/Makefile
+++ b/tools/lib/api/Makefile
@@ -17,13 +17,19 @@ MAKEFLAGS += --no-print-directory
 LIBFILE = $(OUTPUT)libapi.a
 
 CFLAGS := $(EXTRA_WARNINGS) $(EXTRA_CFLAGS)
-CFLAGS += -ggdb3 -Wall -Wextra -std=gnu99 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fPIC
+CFLAGS += -ggdb3 -Wall -Wextra -std=gnu99 -U_FORTIFY_SOURCE -fPIC
 
+ifeq ($(DEBUG),0)
 ifeq ($(CC_NO_CLANG), 0)
   CFLAGS += -O3
 else
   CFLAGS += -O6
 endif
+endif
+
+ifeq ($(DEBUG),0)
+  CFLAGS += -D_FORTIFY_SOURCE
+endif
 
 # Treat warnings as errors unless directed not to
 ifneq ($(WERROR),0)
-- 
2.9.5

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] tools lib api: Fix make DEBUG=1 build Jiri Olsa <jolsa@kernel.org> - 2017-09-08 10:50 +0200
  [PATCH 3/3] perf tools: Add python-clean target Jiri Olsa <jolsa@kernel.org> - 2017-09-08 10:50 +0200
  [PATCH 2/3] perf tools: Open perf.data with O_CLOEXEC flag Jiri Olsa <jolsa@kernel.org> - 2017-09-08 10:50 +0200
    Re: [PATCH 2/3] perf tools: Open perf.data with O_CLOEXEC flag Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-08 20:20 +0200
  Re: [PATCH 1/3] tools lib api: Fix make DEBUG=1 build Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-08 15:40 +0200

csiph-web