Re: [RFC Part2 PATCH v3 02/26] crypto: ccp: Add Platform Security Processor (PSP) device support

From	Borislav Petkov <bp@suse.de>
Newsgroups	linux.kernel
Subject	Re: [RFC Part2 PATCH v3 02/26] crypto: ccp: Add Platform Security Processor (PSP) device support
Date	2017-09-08 10:30 +0200
Message-ID	<unmPL-4eF-11@gated-at.bofh.it> (permalink)
References	<u73o5-oR-3@gated-at.bofh.it> <u73o5-oR-7@gated-at.bofh.it> <un5YB-12W-17@gated-at.bofh.it> <unmPL-4eF-13@gated-at.bofh.it> <unmPL-4eF-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Sep 07, 2017 at 06:15:55PM -0500, Gary R Hook wrote:
> I would prefer that we not shorten this. The prior incarnation,
> ccp_alloc_struct(), has/had been around for a while. And there are a
> number of similarly named allocation functions in the driver that we
> like to keep sorted. If anything, it should be more explanatory, IMO.

Well, looks like an AMD practice:

$ git grep --name-only alloc_struct
drivers/crypto/ccp/ccp-dev.c
drivers/crypto/ccp/ccp-dev.h
drivers/crypto/ccp/psp-dev.c
drivers/crypto/ccp/sev-dev.c
drivers/crypto/ccp/sp-dev.c
drivers/crypto/ccp/sp-dev.h
drivers/crypto/ccp/sp-pci.c
drivers/crypto/ccp/sp-platform.c
drivers/gpu/drm/amd/amdkfd/kfd_dbgmgr.c
drivers/gpu/drm/amd/amdkfd/kfd_priv.h
drivers/gpu/drm/amd/amdkfd/kfd_topology.c

But whatever, if you like it more that way... :)

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--

Thread

Re: [RFC Part2 PATCH v3 02/26] crypto: ccp: Add Platform Security  Processor (PSP) device support Borislav Petkov <bp@suse.de> - 2017-09-07 16:30 +0200
  Re: [RFC Part2 PATCH v3 02/26] crypto: ccp: Add Platform Security  Processor (PSP) device support Borislav Petkov <bp@suse.de> - 2017-09-08 10:30 +0200
  Re: [RFC Part2 PATCH v3 02/26] crypto: ccp: Add Platform Security  Processor (PSP) device support Borislav Petkov <bp@suse.de> - 2017-09-08 10:50 +0200

csiph-web