Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1728610

Re: [PATCH v2] leds: pca955x: Don't invert requested value in pca955x_gpio_set_value()

From Joel Stanley <joel@jms.id.au>
Newsgroups linux.kernel
Subject Re: [PATCH v2] leds: pca955x: Don't invert requested value in pca955x_gpio_set_value()
Date 2017-09-08 08:00 +0200
Message-ID <unkuB-2yh-7@gated-at.bofh.it> (permalink)
References <ukMQp-7T8-5@gated-at.bofh.it> <ukYeR-8i9-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat, Sep 2, 2017 at 2:36 AM, Cédric Le Goater <clg@kaod.org> wrote:
> On 09/01/2017 07:38 AM, Andrew Jeffery wrote:

>> Rework leds-pca955x so that we avoid the incorrect inversion and clarify
>> the semantics with respect to GPIO.
>>
>> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
>
> Reviewed-by: Cédric Le Goater <clg@kaod.org>

I gave this a spin on our 'witherspoon' system and the LEDs responded
as expected.

Tested-by: Joel Stanley <joel@jms.id.au>

Cheers,

Joel

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2] leds: pca955x: Don't invert requested value in pca955x_gpio_set_value() Andrew Jeffery <andrew@aj.id.au> - 2017-09-01 07:40 +0200
  Re: [PATCH v2] leds: pca955x: Don't invert requested value in  pca955x_gpio_set_value() Cédric Le Goater <clg@kaod.org> - 2017-09-01 19:50 +0200
    Re: [PATCH v2] leds: pca955x: Don't invert requested value in pca955x_gpio_set_value() Joel Stanley <joel@jms.id.au> - 2017-09-08 08:00 +0200
  Re: [PATCH v2] leds: pca955x: Don't invert requested value in  pca955x_gpio_set_value() Jacek Anaszewski <jacek.anaszewski@gmail.com> - 2017-09-08 22:20 +0200

csiph-web