Re: [PATCH RFC 2/6] Create new file ksz9477.c from KSZ9477 code in ksz_common.c

From	Andrew Lunn <andrew@lunn.ch>
Newsgroups	linux.kernel
Subject	Re: [PATCH RFC 2/6] Create new file ksz9477.c from KSZ9477 code in ksz_common.c
Date	2017-09-08 02:50 +0200
Message-ID	<unfEB-7Rs-7@gated-at.bofh.it> (permalink)
References	<uncdH-5xq-19@gated-at.bofh.it> <uncdH-5xq-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> +static void ksz_port_cfg(struct ksz_device *dev, int port, int offset, u8 bits,
> +			 bool set)

Hi Tristram

As you move these functions around, it would be good to change the
prefix to ksz9477_

You have similar functions in the KSZ8795 driver. It is good to keep
the names different. This is useful when looking at stack dumps, etc.

    Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH RFC 2/6] Create new file ksz9477.c from KSZ9477 code in  ksz_common.c <Tristram.Ha@microchip.com> - 2017-09-07 23:10 +0200
  Re: [PATCH RFC 2/6] Create new file ksz9477.c from KSZ9477 code in  ksz_common.c Andrew Lunn <andrew@lunn.ch> - 2017-09-07 23:40 +0200
    RE: [PATCH RFC 2/6] Create new file ksz9477.c from KSZ9477 code in  ksz_common.c <Tristram.Ha@microchip.com> - 2017-09-08 00:30 +0200
      Re: [PATCH RFC 2/6] Create new file ksz9477.c from KSZ9477 code in  ksz_common.c Andrew Lunn <andrew@lunn.ch> - 2017-09-08 00:50 +0200
  Re: [PATCH RFC 2/6] Create new file ksz9477.c from KSZ9477 code in  ksz_common.c Andrew Lunn <andrew@lunn.ch> - 2017-09-08 02:50 +0200

csiph-web