Re: [PATCH v8 09/28] x86/insn-eval: Do not BUG on invalid register type

From	Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v8 09/28] x86/insn-eval: Do not BUG on invalid register type
Date	2017-09-07 22:30 +0200
Message-ID	<unbAZ-540-13@gated-at.bofh.it> (permalink)
References	<ufZOh-2z5-3@gated-at.bofh.it> <ufZXY-2C3-43@gated-at.bofh.it> <un9fQ-3ll-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 2017-09-07 at 19:54 +0200, Borislav Petkov wrote:
> 
> Also, I meant to add it to pr_fmt. Feel free to merge this hunk ontop
> of
> yours:
> 
> ---
> diff --git a/arch/x86/lib/insn-eval.c b/arch/x86/lib/insn-eval.c
> index 3919458fecbf..d46034ddfbb7 100644
> --- a/arch/x86/lib/insn-eval.c
> +++ b/arch/x86/lib/insn-eval.c
> @@ -10,6 +10,9 @@
>  #include <asm/insn.h>
>  #include <asm/insn-eval.h>
>  
> +#undef pr_fmt
> +#define pr_fmt(fmt) "insn: " fmt
> +
>  enum reg_type {
>         REG_TYPE_RM = 0,
>         REG_TYPE_INDEX,
> @@ -86,7 +89,7 @@ static int get_reg_offset(struct insn *insn, struct
> pt_regs *regs,
>                 break;
>  
>         default:
> -               pr_err_ratelimited("insn: x86: invalid register
> type");
> +               pr_err_ratelimited("invalid register type: %d\n",
> type);
>                 return -EINVAL;
>         }
>  

Oh, I didn't understand your comment initially. Sure, I will add merge
this on top of my patch.

Thanks and BR,
Ricardo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v8 09/28] x86/insn-eval: Do not BUG on invalid register  type Borislav Petkov <bp@suse.de> - 2017-09-07 20:00 +0200
  Re: [PATCH v8 09/28] x86/insn-eval: Do not BUG on invalid register  type Ricardo Neri <ricardo.neri-calderon@linux.intel.com> - 2017-09-07 22:30 +0200

csiph-web