Re: [PATCH] mm: memcontrol: use per-cpu stocks for socket memory uncharging

From	Shakeel Butt <shakeelb@google.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm: memcontrol: use per-cpu stocks for socket memory uncharging
Date	2017-09-07 21:50 +0200
Message-ID	<unaYh-4Ad-1@gated-at.bofh.it> (permalink)
References	<ujUn0-6IJ-21@gated-at.bofh.it> <ujUn0-6IJ-19@gated-at.bofh.it> <una2f-3SJ-37@gated-at.bofh.it> <una2f-3SJ-35@gated-at.bofh.it> <unaYh-4Ad-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Sep 7, 2017 at 11:47 AM, Roman Gushchin <guro@fb.com> wrote:
> On Thu, Sep 07, 2017 at 11:44:12AM -0700, Shakeel Butt wrote:
>> >> As far as other types of pages go: page cache and anon are already
>> >> batched pretty well, but I think kmem might benefit from this
>> >> too. Have you considered using the stock in memcg_kmem_uncharge()?
>> >
>> > Good idea!
>> > I'll try to find an appropriate testcase and check if it really
>> > brings any benefits. If so, I'll master a patch.
>> >
>>
>> Hi Roman, did you get the chance to try this on memcg_kmem_uncharge()?
>
> Hi Shakeel!
>
> Not yet, I'll try to it asap.
> Do you have an example when it's costly?
>

Nah, I was also curious of such examples.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] mm: memcontrol: use per-cpu stocks for socket memory  uncharging Johannes Weiner <hannes@cmpxchg.org> - 2017-08-29 21:30 +0200
  Re: [PATCH] mm: memcontrol: use per-cpu stocks for socket memory uncharging Shakeel Butt <shakeelb@google.com> - 2017-09-07 20:50 +0200
    Re: [PATCH] mm: memcontrol: use per-cpu stocks for socket memory uncharging Shakeel Butt <shakeelb@google.com> - 2017-09-07 21:50 +0200

csiph-web