Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1729510
| From | Al Viro <viro@ZenIV.linux.org.uk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC 1/2] proc: Return if nothing to unmount |
| Date | 2017-09-09 20:40 +0200 |
| Message-ID | <unSPE-Nx-9@gated-at.bofh.it> (permalink) |
| References | <unPRM-7cK-25@gated-at.bofh.it> <unPRM-7cK-27@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, Sep 09, 2017 at 06:03:16PM +0530, Gargi Sharma wrote: > If a task exits before procfs is mounted, proc_flush_task_mnt will > be called with a NULL mnt parameter. In that case, not only is there > nothing to unhash, but trying to do so will oops the kernel with a > null pointer dereference. You are misreading that sucker. It's about userland mounts, it's about the internal ones in pidns, for each pidns the process belongs to. IOW, what you are adding is dead code. The very first alloc_pid() in that pidns should've called pid_ns_prepare_proc(), which creates that vfsmount.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC 1/2] proc: Return if nothing to unmount Gargi Sharma <gs051095@gmail.com> - 2017-09-09 17:30 +0200
Re: [RFC 1/2] proc: Return if nothing to unmount Al Viro <viro@ZenIV.linux.org.uk> - 2017-09-09 20:40 +0200
Re: [RFC 1/2] proc: Return if nothing to unmount Rik van Riel <riel@surriel.com> - 2017-09-10 22:10 +0200
Re: [RFC 1/2] proc: Return if nothing to unmount Rik van Riel <riel@surriel.com> - 2017-09-11 03:00 +0200
csiph-web