Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1729421

Re: [PATCH 1/4] perf ui progress: Make sure we always define step value

Show all headers | View raw

On Freitag, 8. September 2017 15:26:42 CEST Arnaldo Carvalho de Melo wrote:
> Em Fri, Sep 08, 2017 at 03:16:37PM +0200, Milian Wolff escreveu:
> > On Freitag, 8. September 2017 14:05:07 CEST Jiri Olsa wrote:
> > > +++ b/tools/perf/ui/progress.c
> > > @@ -25,7 +25,7 @@ void ui_progress__update(struct ui_progress *p, u64
> > > adv)
> > > 
> > >  void ui_progress__init(struct ui_progress *p, u64 total, const char
> > >  *title)
> > > 
> > > {
> > > 
> > >  	p->curr = 0;
> > > 
> > > -	p->next = p->step = total / 16;
> > > +	p->next = p->step = total / 16 ?: 1;
> > > 
> > >  	p->total = total;
> > >  	p->title = title;
> > 
> > This is a GNU extension, does this compile with clang?
> 
> Huh?
> 
> [acme@jouet linux]$ find tools/ -name "*.[ch]"| xargs grep ?: | wc -l
> 64
> [acme@jouet linux]$ find . -name "*.[ch]"| xargs grep ?: | wc -l
> 725
> [acme@jouet linux]$
> 
> And yes, tools/perf/ is built with clang regularly, I use containers to
> test build the tools/{perf,lib} codebase with gcc and clang on almost
> all distros, things like:

OK, thanks for the clarification. I was wondering because I didn't know about 
this syntax. Googling I found this: https://en.wikipedia.org/wiki/%3F:#C

Quote:

> A GNU extension to C allows omitting the second operand, and using 
implicitly the first operand as the second also:
>
>     a = x ? : y;

Cheers

-- 
Milian Wolff | milian.wolff@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC 1/4] perf ui progress: Add size info into progress bar Jiri Olsa <jolsa@kernel.org> - 2017-09-08 14:10 +0200
  [PATCH 4/4] perf ui progress: Add size info into progress bar Jiri Olsa <jolsa@kernel.org> - 2017-09-08 14:10 +0200
  [PATCH 1/4] perf ui progress: Make sure we always define step value Jiri Olsa <jolsa@kernel.org> - 2017-09-08 14:10 +0200
    Re: [PATCH 1/4] perf ui progress: Make sure we always define step value Milian Wolff <milian.wolff@kdab.com> - 2017-09-08 15:20 +0200
      Re: [PATCH 1/4] perf ui progress: Make sure we always define step  value Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-08 15:30 +0200
        Re: [PATCH 1/4] perf ui progress: Make sure we always define step value Milian Wolff <milian.wolff@kdab.com> - 2017-09-09 12:20 +0200
  [PATCH 2/4] perf ui progress: Fix progress update Jiri Olsa <jolsa@kernel.org> - 2017-09-08 14:10 +0200
  [PATCH 3/4] perf ui progress: Add ui specific init function Jiri Olsa <jolsa@kernel.org> - 2017-09-08 14:10 +0200
  Re: [RFC 1/4] perf ui progress: Add size info into progress bar Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-08 15:50 +0200

csiph-web